test(ontology): free-text org-unit labels never mint authority - #915
Closed
jason931225 wants to merge 1 commit into
Closed
test(ontology): free-text org-unit labels never mint authority#915jason931225 wants to merge 1 commit into
jason931225 wants to merge 1 commit into
Conversation
Extend binding_seam_tests so empty, Hangul+ASCII, UUID-like-but-short, and substring-UUID labels stay Err. Uppercase and trimmed UUIDs remain accepted. Text probes still cannot reach OrgUnit authority minting.
Collaborator
Author
|
Independent adversarial review REVISE on |
Collaborator
Author
|
Closing: occupancy of an unused parser, not the live bind. The diff only extends Independent review on |
This was referenced Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft. Independent review required before merge. Do not merge from this lane.
Candidate SHA:
b029781cea7b1f2a9f4c3436a3cdbc8f1f877a84Base:
2f99f9ea26b0813e8962c22a2e74f6376530e69b(origin/main)Extend existing
binding_seam_testsonly.unambiguous_legacy_source_idstill accepts onlyUuid::parse_strof the trimmed whole string.free_text_labels_never_mint_authorityalso rejects empty string, Hangul+ASCII mix (영업HQ), UUID-like-but-too-short, and a name that contains a UUID as a substring.uuid_source_ids_are_unambiguousstill accepts uppercase (becauseUuid::parse_strdoes) and whitespace-trimmed UUIDs (because the seam trims).Err(AmbiguousTextAuthority)and cannot mint OrgUnit authority. No new#[test]function.org_unit.rs(feat(ontology): owner-adapter list/get for canonical heads #898) untouched. Production DML unchanged.Lease:
backend/crates/ontology/canonical-adapter-postgres/src/org_unit_binding.rsonly. Disjoint from identity/directory (#897/#908/#909), canonical list/get (#898 — does not include this file), action-inbox (#899), inbox-payslip-filter (#900), attendance personas (#903), auth cookies (#904), FE/UI (#905), attendance CONFIRM parse (#907), and persona ESS HTTP (#910).Tests
discovered 8 lib tests, executed 1, passed 1 (7 filtered out).
Also ran the sibling existing test (same module, still one
#[test]):executed 1, passed 1 (7 filtered out).
merge-tree --write-tree (all exit 0)
origin/main2f99f9eac9d8c558path-overlap nonee390a25epath-overlap none (org_unit.rsonly; this file not in feat(ontology): owner-adapter list/get for canonical heads #898)f861f715path-overlap noneb4ca34abpath-overlap none14944513path-overlap none11645e48path-overlap none5d30ddecpath-overlap nonee5164a42path-overlap none0c2b572cpath-overlap none65fa2123path-overlap none6b8d2de8path-overlap none053b96cdpath-overlap none00ccfb20path-overlap noneaf25cbcapath-overlap noneHOLDs
ensure_unambiguous_legacy_binding_in_txstill takes a typedUuid; this lane does not add a text-to-authority writer.Blast radius / rollback
b029781c. No schema, lockfile, OpenAPI, CI, or runtime change.No merge.