New files (NavBar)

[PlIlchevski]

I followed your instructions in the e-mail.

[justinnhli]

A couple small changes, but otherwise looks good.

[justinnhli]

You probably mean class="genericButton" and not id.

[justinnhli]

Change this to ".genericButton" to make it with with classes

[PlIlchevski]

Okay. I will make the changes and push the files.

…

On Thu, May 24, 2018 at 16:40 Justin Li ***@***.***> wrote: ***@***.**** commented on this pull request. A couple small changes, but otherwise looks good. ------------------------------ In index.html <#24 (comment)> : > @@ -34,6 +34,15 @@ addBlocksHTML(); }; </script> + <button id="genericButton" onclick="buttonUndo()">UNDO</button> + <button id="genericButton" onclick="buttonRedo()">REDO</button> + <button id="genericButton" onclick="buttonDefaultZoom()">DEFAULT ZOOM</button> + <button id="genericButton" onclick="buttonZoomIn()">ZOOM IN</button> + <button id="genericButton" onclick="buttonZoomOut()">ZOOM OUT</button> + <button id="genericButton" onclick="buttonCopy()">COPY</button> + <button id="genericButton" onclick="buttonCut()">CUT</button> + <button id="genericButton" onclick="buttonPaste()">PASTE</button> + <br> You probably mean class="genericButton" and not id. ------------------------------ In stylesheet.css <#24 (comment)> : > @@ -63,5 +63,30 @@ body { #parseButton:disabled { background-color: grey; color: white; - cursor: default; -} + cursor: not-allowed; +} + +#genericButton { Change this to ".genericButton" to make it with with classes — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#24 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AltOVdAP8uGRebdmyxQxjU7mKVA6-fDoks5t10TmgaJpZM4ULg4Z> .

[justinnhli]

Several more things. Also take a look at the CI results and fix them.

[justinnhli]

I am confused by this line - what's data?

[justinnhli]

You'll need to add your new functions into this list to fix the lint.