Skip to content

fix(permissions): v0.5.1 — bug fixes, i18n, and cleanup - #33

Merged
edimedia merged 1 commit into
mainfrom
develop
Jul 24, 2026
Merged

fix(permissions): v0.5.1 — bug fixes, i18n, and cleanup#33
edimedia merged 1 commit into
mainfrom
develop

Conversation

@edimedia

Copy link
Copy Markdown
Member

Bug fixes:

  • E007: replace 'group' (singular) with 'groups' (plural) across checks, utils, and docstrings to match presets.py v0.5.0 format
  • E022: fix false positives on scope ownership — only check conflicts between discovered app presets, not the already-merged base preset
  • any_permission_check(), allowed_for(), denied_for(): add missing is_active=True filter so deactivated grants are properly ignored
  • authorization.py: use getattr(settings, 'ACCESS_MANAGER_SCOPE', 'access') to prevent AttributeError when setting is absent

Internationalization:

  • Translate all exception messages from French to English using _('...').format(...) syntax for proper gettext support
  • Update French .po translations — remove fuzzy markers, fill missing entries, fix python-brace-format placeholders

Cleanup:

  • Remove pagination module (CursorPagination) — controllers already use Django Ninja Extra's PageNumberPaginationExtra
  • Fix variable shadowing (roles -> role_objs) in update_group()
  • Remove dead 'scopes' key from load_preset docstring

Bug fixes:
- E007: replace 'group' (singular) with 'groups' (plural) across checks,
  utils, and docstrings to match presets.py v0.5.0 format
- E022: fix false positives on scope ownership — only check conflicts
  between discovered app presets, not the already-merged base preset
- any_permission_check(), allowed_for(), denied_for(): add missing
  is_active=True filter so deactivated grants are properly ignored
- authorization.py: use getattr(settings, 'ACCESS_MANAGER_SCOPE', 'access')
  to prevent AttributeError when setting is absent

Internationalization:
- Translate all exception messages from French to English using
  _('...').format(...) syntax for proper gettext support
- Update French .po translations — remove fuzzy markers, fill missing
  entries, fix python-brace-format placeholders

Cleanup:
- Remove pagination module (CursorPagination) — controllers already use
  Django Ninja Extra's PageNumberPaginationExtra
- Fix variable shadowing (roles -> role_objs) in update_group()
- Remove dead 'scopes' key from load_preset docstring
@edimedia
edimedia merged commit 1417eba into main Jul 24, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant