Skip to content

Skip Codex checks in plan mode #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dtip merged 1 commit into from
Jul 1, 2026
Merged

Skip Codex checks in plan mode #51

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion codex/plugins/ox/.codex-plugin/plugin.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "ox",
"version": "0.0.20",
"version": "0.0.21",
"description": "Base plugin — commit command, code quality hooks, auto-format and check hooks for all projects",
"author": {
"name": "Oxidian"
Expand Down
4 changes: 2 additions & 2 deletions codex/plugins/ox/hooks.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"hooks": [
{
"type": "command",
"command": "sh -c 'root=\"$(git rev-parse --show-toplevel 2>/dev/null || pwd)\"; bootstrap_dir=\"${CODEX_PLUGINS_BOOTSTRAP_DIR:-.codex/cc-plugins}\"; case \"$bootstrap_dir\" in /*) bootstrap_root=\"$bootstrap_dir\" ;; *) bootstrap_root=\"$root/$bootstrap_dir\" ;; esac; bootstrap_runner=\"$bootstrap_root/codex/plugins/ox/scripts/run_if_changed.py\"; repo_runner=\"$root/codex/plugins/ox/scripts/run_if_changed.py\"; cache_runner=\"$HOME/.codex/plugins/cache/oxidian/ox/0.0.20/scripts/run_if_changed.py\"; if [ -f \"$bootstrap_runner\" ]; then runner=\"$bootstrap_runner\"; elif [ -f \"$repo_runner\" ]; then runner=\"$repo_runner\"; elif [ -f \"$cache_runner\" ]; then runner=\"$cache_runner\"; else echo \"ox hook runner not found; checked $bootstrap_runner, $repo_runner, and $cache_runner\" >&2; exit 2; fi; exec python3 \"$runner\" --runtime codex --action fast'",
"command": "sh -c 'root=\"$(git rev-parse --show-toplevel 2>/dev/null || pwd)\"; bootstrap_dir=\"${CODEX_PLUGINS_BOOTSTRAP_DIR:-.codex/cc-plugins}\"; case \"$bootstrap_dir\" in /*) bootstrap_root=\"$bootstrap_dir\" ;; *) bootstrap_root=\"$root/$bootstrap_dir\" ;; esac; bootstrap_runner=\"$bootstrap_root/codex/plugins/ox/scripts/run_if_changed.py\"; repo_runner=\"$root/codex/plugins/ox/scripts/run_if_changed.py\"; cache_runner=\"$HOME/.codex/plugins/cache/oxidian/ox/0.0.21/scripts/run_if_changed.py\"; if [ -f \"$bootstrap_runner\" ]; then runner=\"$bootstrap_runner\"; elif [ -f \"$repo_runner\" ]; then runner=\"$repo_runner\"; elif [ -f \"$cache_runner\" ]; then runner=\"$cache_runner\"; else echo \"ox hook runner not found; checked $bootstrap_runner, $repo_runner, and $cache_runner\" >&2; exit 2; fi; exec python3 \"$runner\" --runtime codex --action fast'",
"timeout": 30,
"statusMessage": "Running fast checks"
}
Expand All @@ -18,7 +18,7 @@
"hooks": [
{
"type": "command",
"command": "sh -c 'root=\"$(git rev-parse --show-toplevel 2>/dev/null || pwd)\"; bootstrap_dir=\"${CODEX_PLUGINS_BOOTSTRAP_DIR:-.codex/cc-plugins}\"; case \"$bootstrap_dir\" in /*) bootstrap_root=\"$bootstrap_dir\" ;; *) bootstrap_root=\"$root/$bootstrap_dir\" ;; esac; bootstrap_runner=\"$bootstrap_root/codex/plugins/ox/scripts/run_if_changed.py\"; repo_runner=\"$root/codex/plugins/ox/scripts/run_if_changed.py\"; cache_runner=\"$HOME/.codex/plugins/cache/oxidian/ox/0.0.20/scripts/run_if_changed.py\"; if [ -f \"$bootstrap_runner\" ]; then runner=\"$bootstrap_runner\"; elif [ -f \"$repo_runner\" ]; then runner=\"$repo_runner\"; elif [ -f \"$cache_runner\" ]; then runner=\"$cache_runner\"; else echo \"ox hook runner not found; checked $bootstrap_runner, $repo_runner, and $cache_runner\" >&2; exit 2; fi; exec python3 \"$runner\" --runtime codex --action slow'",
"command": "sh -c 'root=\"$(git rev-parse --show-toplevel 2>/dev/null || pwd)\"; bootstrap_dir=\"${CODEX_PLUGINS_BOOTSTRAP_DIR:-.codex/cc-plugins}\"; case \"$bootstrap_dir\" in /*) bootstrap_root=\"$bootstrap_dir\" ;; *) bootstrap_root=\"$root/$bootstrap_dir\" ;; esac; bootstrap_runner=\"$bootstrap_root/codex/plugins/ox/scripts/run_if_changed.py\"; repo_runner=\"$root/codex/plugins/ox/scripts/run_if_changed.py\"; cache_runner=\"$HOME/.codex/plugins/cache/oxidian/ox/0.0.21/scripts/run_if_changed.py\"; if [ -f \"$bootstrap_runner\" ]; then runner=\"$bootstrap_runner\"; elif [ -f \"$repo_runner\" ]; then runner=\"$repo_runner\"; elif [ -f \"$cache_runner\" ]; then runner=\"$cache_runner\"; else echo \"ox hook runner not found; checked $bootstrap_runner, $repo_runner, and $cache_runner\" >&2; exit 2; fi; exec python3 \"$runner\" --runtime codex --action slow'",
"timeout": 120,
"statusMessage": "Running final checks"
}
Expand Down
7 changes: 4 additions & 3 deletions codex/plugins/ox/scripts/run_if_changed.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,6 +376,10 @@ def main() -> None:
if not project_dir:
parser.error("--project-dir is required unless --runtime codex can derive cwd")

if args.runtime == RUNTIME_CODEX and hook_input and hook_input.get("permission_mode") == "plan":
_emit(args.runtime, "Plan mode active, skipping")
sys.exit(SUCCESS_CODE)

# Read config
config_file = os.path.join(project_dir, CONFIG_PATH)
if not os.path.exists(config_file):
Expand All @@ -390,9 +394,6 @@ def main() -> None:
_emit(args.runtime, f"No checks configured in {CONFIG_PATH}, skipping")
sys.exit(SUCCESS_CODE)

if hook_input and hook_input.get("permission_mode") == "plan":
_emit(args.runtime, "Plan mode active, skipping")
sys.exit(SUCCESS_CODE)
if hook_input and args.action == "slow" and _is_team_lead_session(session_id):
_emit(args.runtime, "Agent team lead session, skipping stop checks")
sys.exit(SUCCESS_CODE)
Expand Down
2 changes: 1 addition & 1 deletion plugins/ox/.claude-plugin/plugin.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "ox",
"description": "Base plugin — commit command, code quality hooks, auto-format and check hooks for all projects",
"version": "0.0.20",
"version": "0.0.21",
"author": {
"name": "Oxidian"
}
Expand Down
7 changes: 4 additions & 3 deletions plugins/ox/scripts/run_if_changed.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,6 +376,10 @@ def main() -> None:
if not project_dir:
parser.error("--project-dir is required unless --runtime codex can derive cwd")

if args.runtime == RUNTIME_CODEX and hook_input and hook_input.get("permission_mode") == "plan":
_emit(args.runtime, "Plan mode active, skipping")
sys.exit(SUCCESS_CODE)

# Read config
config_file = os.path.join(project_dir, CONFIG_PATH)
if not os.path.exists(config_file):
Expand All @@ -390,9 +394,6 @@ def main() -> None:
_emit(args.runtime, f"No checks configured in {CONFIG_PATH}, skipping")
sys.exit(SUCCESS_CODE)

if hook_input and hook_input.get("permission_mode") == "plan":
_emit(args.runtime, "Plan mode active, skipping")
sys.exit(SUCCESS_CODE)
if hook_input and args.action == "slow" and _is_team_lead_session(session_id):
_emit(args.runtime, "Agent team lead session, skipping stop checks")
sys.exit(SUCCESS_CODE)
Expand Down
29 changes: 27 additions & 2 deletions tests/ox/test_run_if_changed.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,12 +81,12 @@ def _init_branch_changed_repo(tmp_path: Path, command: str, *, base_ref: str = "
return subdir


def _run_codex_hook(cwd: Path, action: str) -> subprocess.CompletedProcess[str]:
def _run_codex_hook(cwd: Path, action: str, *, permission_mode: str = "default") -> subprocess.CompletedProcess[str]:
payload = {
"session_id": f"test-{action}",
"cwd": str(cwd),
"hook_event_name": "Stop" if action == "slow" else "PostToolUse",
"permission_mode": "default",
"permission_mode": permission_mode,
}
return subprocess.run(
[sys.executable, str(_script_path), "--runtime", "codex", "--action", action],
Expand Down Expand Up @@ -289,6 +289,31 @@ def test_failure_exits_two_with_feedback_on_stderr(self, tmp_path: Path) -> None
assert "Final checks failed. Fix these issues before finishing." in result.stderr
assert "bad check output" in result.stderr

def test_plan_mode_slow_skips_failing_checks(self, tmp_path: Path) -> None:
check_script = tmp_path / "check.py"
check_script.write_text("import sys\nprint('bad check output')\nsys.exit(1)\n")
subdir = _init_changed_repo(tmp_path, _command_for_script(check_script))

result = _run_codex_hook(subdir, "slow", permission_mode="plan")

assert result.returncode == 0
assert result.stdout == ""
assert result.stderr == ""

def test_plan_mode_slow_skips_before_config_parsing(self, tmp_path: Path) -> None:
subprocess.run(["git", "init"], cwd=tmp_path, check=True, capture_output=True, text=True)
(tmp_path / ".claude").mkdir()
(tmp_path / ".claude" / "ox-hooks.json").write_text("{not json\n")
(tmp_path / "changed.txt").write_text("changed\n")
subdir = tmp_path / "subdir"
subdir.mkdir()

result = _run_codex_hook(subdir, "slow", permission_mode="plan")

assert result.returncode == 0
assert result.stdout == ""
assert result.stderr == ""

def test_slow_runs_for_committed_branch_changes(self, tmp_path: Path) -> None:
marker = tmp_path / "marker.txt"
check_script = tmp_path / "check.py"
Expand Down
Loading