observer: remove PSU's auxiliary rail - #2653
Merged
Merged
Conversation
hawkw
reviewed
Aug 19, 2026
Comment on lines
+445
to
+448
| # rail is accessible over PMBus. The PSU does allow you to set the page to 0 or | ||
| # 1, but this has no effect; in either case, commands like READ_VOUT just report | ||
| # readings for the main rail, and Murata has confirmed that this is the intended | ||
| # behavior. Therefore, we only define the main rail here. |
Member
There was a problem hiding this comment.
man, that's so cool. why would they design it like that???
hawkw
approved these changes
Aug 19, 2026
hawkw
left a comment
hawkw
left a comment
Member
There was a problem hiding this comment.
well, that's unfortunate (but in no way your fault). good job murata, very nice.
| struct EreportFields { | ||
| refdes: FixedStr<'static, 20>, // Component ID max length | ||
| rail: FixedString<13>, // Example: "V54_PSU0" | ||
| rail: FixedString<8>, // Example: "V54_PSU0" |
Member
There was a problem hiding this comment.
well, that's nice, i guess, at least.
| description = "PSU 0 MCU" | ||
| # TODO it's not clear what rails the mwocp67 has or how they are paged. | ||
| # https://github.com/oxidecomputer/hubris/issues/2410 | ||
| power = { rails = [ "V50_MAIN_PSU0", "V50_AUX_PSU0" ], sensors = ["voltage", "current", "input-voltage", "input-current"] } |
Member
There was a problem hiding this comment.
it has occurred to me that even if the aux rail did work, we would have needed to change its name here, since it's not 50V.
jamesmunns
approved these changes
Aug 20, 2026
jamesmunns
left a comment
jamesmunns
left a comment
Contributor
There was a problem hiding this comment.
Glad to hear the snapshot updating wasn't painful!
This only affects the mwocp67 and not the mwocp68, right?
Contributor
Author
Correct, we can still read the mwocp68's aux rail. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It turns out that the MWOCP67 PSU's auxiliary rail is not accessible over PMBus, so this PR removes it from the manifest. I had to update the i2c codegen snapshot tests, but it was actually quite nice to see what had changed.
Tested by running
humility powerand confirming that now only the main rail of each PSU is shown.