feat: allow multi fastas#11
Merged
Merged
Conversation
JeremyWesthead
requested review from
bobturneruk,
mcolpus,
ngochieu642 and
viktoria023
July 15, 2026 14:46
mcolpus
approved these changes
Jul 21, 2026
mcolpus
left a comment
There was a problem hiding this comment.
Looks good to me from reading through code changes. Just to confirm your intending to remove the tree building package (I assume because we don't really use it)
Collaborator
Author
|
It's a slightly niche use case, but actually the reason for removal is difficulties with the python packaging. It would either package just the scripts or just the rust library. Obviously the priority is the rust library, and without the packaging, they become relatively useless in this repo I have vague (incredibly low priority) ideas about adding a rust implementation to keep the functionality as it's quite neat though |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables parsing FN6 saves from (gzipped) multi fastas which should improve use experience