fix: add Yarn PnP support via yarn exec#144
Open
SBoudrias wants to merge 1 commit into
Open
Conversation
When a project uses Yarn Berry's Plug'n'Play mode (.pnp.cjs/.pnp.js), switch from `node node_modules/pkg/bin/pkg --lsp` to `yarn exec pkg --lsp` since node_modules doesn't exist on disk under PnP.
Author
|
I considered adding a config option to pass in a path, but that was more complicated given the bin path isn't detectable... But I do understand this adds a yarn PnP specific understanding to this project; hopefully it's not something you're fundamentally against. 🫰 |
SBoudrias
marked this pull request as ready for review
March 18, 2026 21:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The plugin fails in projects using Yarn PnP mode because it hardcodes paths like
node_modules/{pkg}/bin/{pkg}. Under Yarn PnP, there is nonode_moduleson disk — packages are zip-loaded from.yarn/cache/.Solution
Detect Yarn PnP by checking for
.pnp.cjsor.pnp.jsat the worktree root, and switch the launch strategy:node {worktree}/node_modules/oxlint/bin/oxlint --lspyarn exec oxlint --lspChanges
src/lsp.rs: Addedis_yarn_pnp()helper andget_default_command_and_args()trait methodsrc/oxlint.rs: Usesget_default_command_and_args()instead of manually constructingnode <path>src/oxfmt.rs: SameBehaviour
node_modulespresent → existing path logic (no regression).pnp.cjspresent →yarn exec oxlint --lspnodeLinker: node-modules.pnp.cjs→ existing path logic