Skip to content

chore(extension): add the darktorch extension#127

Open
davrodpin wants to merge 1 commit into
owlbear-rodeo:mainfrom
davrodpin:add-shadowdark
Open

chore(extension): add the darktorch extension#127
davrodpin wants to merge 1 commit into
owlbear-rodeo:mainfrom
davrodpin:add-shadowdark

Conversation

@davrodpin

Copy link
Copy Markdown

Real-time torch timer for Shadowdark RPG, built for the Owlbear Rodeo virtual tabletop.

Make sure that your submission has the following:

  • A link to the raw github markdown file with a YAML front matter definition containing:
    • The title of your extension
    • A description of your extension
    • The author
    • A hero image
    • An icon
    • Tags (these will help with your extension's discoverability)
    • A link to your extensions manifest

Please, go through these steps before you submit a PR.

  • You have done your changes in a separate branch.

  • You have a descriptive commit message with a short title (first line).

  • You have only one commit (if not, squash them into one commit).

  • Your pull request MUST target the main branch on this repository.

  • Your pull request puts your extensions details as the last entry in the extensions.json file

@Several-Record7234

Copy link
Copy Markdown
Collaborator

Hi @davrodpin,

Thanks for submitting this extension to the official store. I've run the first-level verification and your store.md file has failed the tags test: "tags:" must be one of [dice, fog, tool, content-pack, drawing, audio, combat, automation, other] - please would you edit the file to comply with this limited set of options, and let me know so that I can progress the verification process? Thanks!

@davrodpin

Copy link
Copy Markdown
Author

Thanks for submitting this extension to the official store. I've run the first-level verification and your store.md file has failed the tags test: "tags:" must be one of [dice, fog, tool, content-pack, drawing, audio, combat, automation, other] - please would you edit the file to comply with this limited set of options, and let me know so that I can progress the verification process? Thanks!

Hi @Several-Record7234, I just updated the document with the proper tags. I completely missed that, my bad. I think the store.md file is ready to be reviewed again. Thanks!

@Several-Record7234

Copy link
Copy Markdown
Collaborator

@davrodpin Hmm, I'm still getting this detail at the top of your store.md, even with an 'empty cache and hard refresh' for its URL:
image

Is there a file update that hasn't trickled through yet?

@davrodpin

Copy link
Copy Markdown
Author

Hmm, I'm still getting this detail at the top of your store.md, even with an 'empty cache and hard refresh' for its URL:

@Several-Record7234, apologies one more time. I updated the file in my repository but forgot to release it to production. I've done that and checked the tag is the expected one in https://davrodpin.github.io/darktorch/docs/STORE.md.

@Several-Record7234

Copy link
Copy Markdown
Collaborator

@davrodpin, thanks that's now passed first verification 👍 The second stage verification will happen towards the end of February when Nicola takes over.

@Several-Record7234

Copy link
Copy Markdown
Collaborator

Validation script and image URLs check out fine. 'Learn-more' link is fine.

Extension functionality and API usage not checked.

@davrodpin

Copy link
Copy Markdown
Author

@davrodpin, thanks that's now passed first verification 👍 The second stage verification will happen towards the end of February when Nicola takes over.

Thanks a bunch!

Extension functionality and API usage not checked.

@Several-Record7234 , is there anything I can proactively check about the API usage to ease the verification process?

@nthouliss nthouliss left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davrodpin sorry for the wait. I review once a month and had to skip Feb for personal reasons.

Is there a reason you're polling to get the player ID? You can use the Party API if you're just trying to detect changes to the players (i.e. if they join or leave).

Real-time torch timer for Shadowdark RPG, built for the Owlbear Rodeo virtual tabletop.
@davrodpin

Copy link
Copy Markdown
Author

Hi @nthouliss,

Is there a reason you're polling to get the player ID? You can use the Party API if you're just trying to detect changes to the players (i.e. if they join or leave).

Thanks for the review! To clarify: the repeated getId() wasn't actually reading the player ID, it was a leftover connection-health heartbeat that discarded the result. Player join/leave/role detection was already event-driven via OBR.player.onChange. Since extension iframes stay connected once onReady fires, I've removed the heartbeat entirely rather than converting it. Happy to wire up OBR.party.onChange if a future feature needs to react to
other players joining or leaving.

As part of this fix, we removed the 5-second polling interval and the associated reconnection state machinery, and replaced the one place that depended on it with an event-driven trigger on SDK readiness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants