chore(extension): add the darktorch extension#127
Conversation
|
Hi @davrodpin, Thanks for submitting this extension to the official store. I've run the first-level verification and your store.md file has failed the tags test: |
Hi @Several-Record7234, I just updated the document with the proper tags. I completely missed that, my bad. I think the |
|
@davrodpin Hmm, I'm still getting this detail at the top of your store.md, even with an 'empty cache and hard refresh' for its URL: Is there a file update that hasn't trickled through yet? |
@Several-Record7234, apologies one more time. I updated the file in my repository but forgot to release it to production. I've done that and checked the tag is the expected one in https://davrodpin.github.io/darktorch/docs/STORE.md. |
|
@davrodpin, thanks that's now passed first verification 👍 The second stage verification will happen towards the end of February when Nicola takes over. |
|
Validation script and image URLs check out fine. 'Learn-more' link is fine. Extension functionality and API usage not checked. |
Thanks a bunch!
@Several-Record7234 , is there anything I can proactively check about the API usage to ease the verification process? |
nthouliss
left a comment
There was a problem hiding this comment.
@davrodpin sorry for the wait. I review once a month and had to skip Feb for personal reasons.
Is there a reason you're polling to get the player ID? You can use the Party API if you're just trying to detect changes to the players (i.e. if they join or leave).
Real-time torch timer for Shadowdark RPG, built for the Owlbear Rodeo virtual tabletop.
|
Hi @nthouliss,
Thanks for the review! To clarify: the repeated As part of this fix, we removed the 5-second polling interval and the associated reconnection state machinery, and replaced the one place that depended on it with an event-driven trigger on SDK readiness. |

Real-time torch timer for Shadowdark RPG, built for the Owlbear Rodeo virtual tabletop.
Make sure that your submission has the following:
Please, go through these steps before you submit a PR.
You have done your changes in a separate branch.
You have a descriptive commit message with a short title (first line).
You have only one commit (if not, squash them into one commit).
Your pull request MUST target the
mainbranch on this repository.Your pull request puts your extensions details as the last entry in the extensions.json file