Add GM Vault extension

[lolergb]

Make sure that your submission has the following:

• A link to the raw github markdown file with a YAML front matter definition containing:
  • The title of your extension
  • A description of your extension
  • The author
  • A hero image
  • An icon
  • Tags (these will help with your extension's discoverability)
  • A link to your extensions manifest

Please, go through these steps before you submit a PR.

• You have done your changes in a separate branch.

• You have a descriptive commit message with a short title (first line).

• You have only one commit (if not, squash them into one commit).

• Your pull request MUST target the main branch on this repository.

• Your pull request puts your extensions details as the last entry in the extensions.json file

[Several-Record7234]

Hi @lolergb,

I'm just running first-line verification on your submission, and it's failing on the tags field in the manifest:
"tags" must be one of [dice, fog, tool, content-pack, drawing, audio, combat, automation, other]

Please could you choose from this list of approved tags, I would suggest that tool would make sense to me. When you've changed that, let me know and I'll run verification again, thanks!

[Several-Record7234]

On further investigation of the extension, I've noticed that you are including copyrighted material without permission to share it - please remove this, and only use material that's publicly available or for which you have written permission to share (we may ask you to prove that you have permission, but it's best practice to include a footnote naming or linking to the copyright licence for the material included, like the D&D System Reference Document.

Until your extension only includes public domain, copyright-free, or other permitted materials, we won't be able to publish it to our official webstore, thanks for your co-operation on this!

[lolergb]

Hi @Several-Record7234!!!
Thanks for the heads-up!

I've updated the manifest to use the approved tool tag, as you suggested.

I've also removed any bundled copyrighted material. The extension now only includes original example content and references to open-licensed material.
All rules references are derived from the D&D 5.1 System Reference Document (SRD), licensed under CC-BY-4.0, and a clear Licensing & Attribution section has been added to the repo.

Please let me know if anything else is needed.

Thanks!

[Several-Record7234]

Validation script and image URLs check out fine.

Extension loads OK, no dev console warnings/errors, but functionality and API usage not checked.

[Several-Record7234]

Hi @Several-Record7234!!! Thanks for the heads-up!

I've updated the manifest to use the approved tool tag, as you suggested.

I've also removed any bundled copyrighted material. The extension now only includes original example content and references to open-licensed material. All rules references are derived from the D&D 5.1 System Reference Document (SRD), licensed under CC-BY-4.0, and a clear Licensing & Attribution section has been added to the repo.

Please let me know if anything else is needed.

Thanks!

This is all great, but it looks like some issues remain in v1.1.0's demo content:

1. Start Here > Opening Scene gives me a 404 error
2. Start Here > Handout — Mysterious Map and Act I > Encounter > Map looks like an image owned by Wizards of the Coast - is this covered by the 5.1 SRD?
3. Start Here > Enemy — Goblin seems to pull data directly from the 5e.tools site, which would be a no-no!
4. Session > Session Notes looks like it has a Gen-AI image, which might gain you some backlash from users

[lolergb]

Hey! Sorry about the mix-up!

I updated default-config on the beta branch instead of main. Getting old is rough 😅

It should now load the corrected configuration.

Thanks for being there and for taking the time to review it ^_^

[lolergb]

@Several-Record7234 @nthouliss I didn’t think about that before, but I can enable a token for you if you need to see the extension’s console.log. Just let me know!

[nthouliss]

@lolergb I can see the extension making a request for the role every 3 seconds, is there a need to check this often?

[lolergb]

Ey @nthouliss!!! Maybe I went a bit too far making a request every 3 seconds, right? 😅 I did it because I couldn’t find any trigger to detect when a player gets promoted to co-GM.

I’m totally open to any alternative approach ^^

Thankssssss!

[davidsev]

I did it because I couldn’t find any trigger to detect when a player gets promoted to co-GM.

Player.onChange should have it.

[lolergb]

@davidsev yeah! Thanks a lot for your help ^__^
I’m applying the same approach in the beta I’m working on now!

@nthouliss fixed!!!
Really, thank you all from the bottom of my heart 💙

[lolergb]

Hey folks! 👋

I’ve been thinking ... would it be better to close this MR and open a new one with the updated GM Vault version?

Happy to do whichever you think makes more sense. What do you think @nthouliss @Several-Record7234 ?

Thank a lot!

[nthouliss]

@lolergb sorry for the wait, I do extension review about once a month and had to skip Feb for personal reasons. I'm happy for you to update the listing against this PR if you'd like and we can run through the review process again 😄

[lolergb]

No worries at all @nthouliss , and thanks so much for the update 💛
I hope everything is okay on your side too.

Yes, absolutely, I’d be happy to update the listing against this PR and go through the review process again 😄

And thank you again for taking the time to review it, really appreciate it!

[nthouliss]

@lolergb just let us know when you're ready for us to re-review 😄