Fix beam pointing antenna-health fallback - #79
Open
peijin94 wants to merge 1 commit into
Open
Conversation
Contributor
|
I think a patch to improve reliability is good. However, it sounds like the |
Contributor
|
@peijin94 I'm sorry, but you'll need to rebase after my latest commit to main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
data.
caltablebad-antenna list toselfcorrwhen caltable state is unavailable.LWA-002Aand002Aantenna-name formats before converting them to correlator numbers.Why
Beam 5 scheduled recordings were starting, but each scheduled pointing update aborted while reading
/mon/anthealth/ caltable. The missing value was dereferenced as a dictionary, producing:'NoneType' object is not subscriptableConsequently, no fresh beam coefficients were sent.
Using
selfcorrdirectly exposed a second issue: its antenna names already include theLWA-prefix, whilecontrol_bfalways added another prefix. Names such asLWA-002Atherefore becameLWA-LWA-002and failedcorrelator mapping.
This patch lets pointing continue with the available
selfcorrhealth list and handles either supported antenna-namerepresentation.
Validation
deploymentPython environment.python -m py_compile mnc/control.py mnc/anthealth.py tests/test_control.pypasses.Modified files:
Deployment safety and rollback
Before applying the live recovery patch, copies of the original deployed files were preserved on
lwacalim10:/opt/devel/pipeline/envs/deployment/lib/python3.6/site-packages/mnc/control.py.pre-beamfix-20260817/opt/devel/pipeline/envs/deployment/lib/python3.6/site-packages/mnc/anthealth.py.pre-beamfix-20260817These backups provide a direct rollback path if the deployed changes need to be reverted. The scheduler was not
restarted during the active observation.