Dogfood otel-scrape in devenv tasks#880
Draft
schickling-assistant wants to merge 3 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
otel-scrapewas implemented and validated as a wrapper, but effect-utils itself was not yet using it across its own build/dev quality gates. That left the dogfooding phase of #866 open and made task-level OTEL gaps easy to reintroduce.Goal
Route effect-utils devenv task execution through
otel-scrapeby default while preserving script-visible behavior, local summary fallback, and the existingotel-spantask spans.Decisions
otel-scrapeoutside the existingtrace.nixotel-spanwrapper, preserving currentdevenv.task.*spans while adding wrapper-owned command/process evidence.OTEL_SCRAPE_DOGFOOD=0; missingotel-scrapefalls back to the original task body.tmp/otel-scrape-dogfood/summariesby default so contributors get local proof without an OTLP backend.otel-scrape:dogfood-audittocheck:*to fail when active task modules add unwrapped exec/status scripts.ptrace-experimentalopt-in; exact-by-default process observation remains helper-gated rather than ptrace- or snapshot-backed.Verification
nix build .#otel-scrape --no-linkpassed.OTEL_SCRAPE_SUMMARY_DIR=tmp/m19-dogfood-verify devenv tasks run genie:prepare --no-tuipassed and producedotel-scrape.summary/v1direct-child degraded process evidence.OTEL_SCRAPE_SUMMARY_DIR=tmp/m19-dogfood-verify devenv tasks run otel-scrape:dogfood-audit --no-tuipassed.CARGO_TARGET_DIR=$PWD/tmp/m20-cargo-target RUSTC_WRAPPER= CI=1 devenv shell cargo test --manifest-path packages/@overeng/otel-scrape/Cargo.tomlpassed.CI=1 OTEL_SCRAPE_SUMMARY_DIR=tmp/m20-check-all-final devenv tasks run check:all --no-tuipassed.Friction & bottlenecks
node-cpuprofilepackage test required Node but the derivation did not declare it.check:allrun hit resource-contention timeouts in package tests; the affected lanes passed individually, and the final cached full gate passed after deterministic fixture updates.Refs #866.