Skip to content

Fix/ingress-evaluate-config-kwarg-forwarding #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LenGul merged 3 commits into from
Aug 19, 2026
+4 −4
Merged

Fix/ingress-evaluate-config-kwarg-forwarding #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6b99422
fix(runtime): forward config as kwarg in ingress evaluate path
LenGul Aug 18, 2026
ce58e3c
fix(runtime): forward config as kwarg in ingress evaluate path
LenGul Aug 18, 2026
9d8d136
test(runtime): accept config kwarg in ingress evaluate stub
LenGul Aug 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion library-standard/src/mas/library/standard/plugins/design_patterns/linear.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ class DeterministicLinearPlugin(_DeterministicBase):
plugin_id = "deterministic_linear@v1"
mode = "linear"

def evaluate_next(self, q: QProduct, run: RunLedger, *, config: KernelConfig) -> list[EgressSymbol]:
def evaluate_next(self, q: QProduct, run: RunLedger, config: KernelConfig) -> list[EgressSymbol]:
st = self._state()
if not st.participants:
return self._no_participants(q)
Expand Down
4 changes: 2 additions & 2 deletions runtime/src/mas/runtime/kernel/ingress_step.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ def commit_engine_io_return(
q.dp = DpState.EVALUATING
apply_control_valid(q)
coord_after_ingress(q)
return evaluate(q, run, config)
return evaluate(q, run, config=config)


def apply_engine_io_return(
Expand Down Expand Up @@ -203,6 +203,6 @@ def apply_engine_io_return(
)
q.inflight_kind = "NONE"
q.dp = DpState.EVALUATING
return evaluate(q, run, config)
return evaluate(q, run, config=config)

return commit_engine_io_return(q, run, event, config=config, evaluate=evaluate)
2 changes: 1 addition & 1 deletion runtime/tests/test_parallel_tools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ def test_schedule_parallel_tools_egress_siblings_share_one_parent() -> None:
text="ok",
)
with runtime_binding(None, op):
apply_engine_io_return(q, run, event, config=config, evaluate=lambda *_: [])
apply_engine_io_return(q, run, event, config=config, evaluate=lambda *_, **__: [])

ends = [
e
Expand Down
Loading