Skip to content

Fix Steam review failures: clean-machine launch, capsule art rules#442

Merged
charneykaye merged 1 commit into
mainfrom
fix/steam-clean-machine-launch
Jul 23, 2026
Merged

Fix Steam review failures: clean-machine launch, capsule art rules#442
charneykaye merged 1 commit into
mainfrom
fix/steam-clean-machine-launch

Conversation

@charneykaye

Copy link
Copy Markdown
Contributor

Fixes the two Valve review failures for app 4963030 (build 24203272):

  1. Build doesn't launch on clean Windows: the Rust/MSVC exe dynamically linked vcruntime140.dll, which isn't present on Valve's clean review images. Fixed with +crt-static in .cargo/config.toml, plus app-local VC++ runtime DLLs shipped at the depot root and in resources/runtimes/ for the bundled llama.cpp binaries.
  2. Capsule/library assets contained extra text: tagline and publisher wordmark removed from header/main/vertical capsules and library header (regenerated, tracked in publishing/assets/, and already uploaded to Steamworks).

Also hardens the Linux depot: version-stable ConversationSimulator.AppImage launch filename and no .deb installer in the depot.

Release plan: tag v0.2.4 on this commit; steam-deploy stages the build; set live on default in Steamworks; mark build + store page for re-review.

Valve build review of v0.2.3 (BuildID 24203272, Jul 22 2026) failed with
"the app does not launch when done through the Steam client or through the
game folders", and the store-presence review flagged capsule/library assets
containing extra text.

Launch fix (Windows, clean machines):
- apps/desktop/src-tauri/.cargo/config.toml: build the Tauri exe with
  +crt-static so ConversationSimulator.exe no longer needs vcruntime140.dll.
  Valve tests on clean Windows images where the VC++ Redistributable is not
  present; a default Rust/MSVC build dynamically links vcruntime140.dll, so
  the exe failed to start at process load - both via Steam client and from
  the game folder, exactly as the reviewer reported. The WebView2 dependency
  was already handled by installscript.vdf; the VC runtime was the remaining
  clean-machine dependency.
- release.yml (Package Windows portable depot layout): additionally ship
  vcruntime140.dll / vcruntime140_1.dll / msvcp140.dll app-locally at the
  depot root (belt-and-suspenders for the exe) and in resources/runtimes/
  (load-bearing for llama-server.exe and the ggml DLLs, which remain
  dynamically linked and previously had no CRT next to them).

Linux depot hardening (steam-deploy.yml):
- Stage the AppImage as version-stable ConversationSimulator.AppImage; the
  Steamworks launch option was pinned to the versioned 0.2.3 filename which
  breaks on every version bump. The Steamworks launch option is updated to
  the stable name.
- Stop staging the .deb into the Linux depot: installer packages in depots
  fail Valve review (same rule as NSIS/MSI on Windows).

Store asset fix (capsules v3):
- Removed the marketing tagline and the OUTRIGHT MENTAL publisher wordmark
  from header/main/vertical capsules and the library header; Steam capsules
  may contain only game artwork, the game name, and an official subtitle
  (https://partner.steamgames.com/doc/store/assets/rules). Compositions
  re-centred; regenerated PNGs and their SVG sources are now tracked in
  publishing/assets/ so the repo matches what is uploaded in Steamworks.
@charneykaye
charneykaye merged commit 5e2d618 into main Jul 23, 2026
22 checks passed
@charneykaye
charneykaye deleted the fix/steam-clean-machine-launch branch July 23, 2026 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant