Include shipping weight details in product data

[Andrew998]

Added shipping weight details for Google Merchant, formatted as a string with 6 decimal places. Included condition to check for product weight before adding to data.

[vseager]

@Andrew998 Thanks for the contribution. This should respect the module config:

$this->getConfig('structureddata/product/include_weight')

Also, why rounding to 6 decimal places? Magneto rounds to 4 decimal places, so this seems unnecessary.

[Andrew998]

Thanks. I'm not too familiar with coding for Magento so all comments are welcome.

Is the process that I make those changes to the contribution?

[vseager]

Hi Andrew,

Yes please go ahead and update your merge request and we will review it again for you. If not, we can put it in our roadmap to implement at a later date.

[vseager]

The latest commit removes the check for a valid weight on the product. As well as checking if the config allows weight to be included, you must still check that a weight existing on the product. See the short description as an example of this logic.

[Andrew998]

Thank you. I'll get there eventually!

[Andrew998]

This is ready for review. Shipping weight is the one thing missing for Google Merchant account to pick up all details without needing a feed.

[kilo-code-bot]

Code Review Summary

Status: 3 Issues Found | Recommendation: Address before merge

Overview

Severity	Count
CRITICAL	0
WARNING	3
SUGGESTION	0

Issue Details (click to expand)

WARNING

File	Line	Issue
Model/Type/Product.php	374	The new shipping-details output bypasses the existing include_weight configuration.
Model/Type/Product.php	375	The code uses four decimal places while the change claims six.
Model/Type/Product.php	378	weight is not a valid property of OfferShippingDetails, so consumers will not receive a schema-valid shipping weight.

Files Reviewed (1 file)

• Model/Type/Product.php - 3 issues

Fix these issues in Kilo Cloud

Previous Review Summary (commit bb689e3)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit bb689e3)

Status: 3 Issues Found | Recommendation: Address before merge

Overview

Severity	Count
CRITICAL	0
WARNING	3
SUGGESTION	0

Issue Details (click to expand)

WARNING

File	Line	Issue
Model/Type/Product.php	374	The new shipping-details output bypasses the existing include_weight configuration.
Model/Type/Product.php	375	The code uses four decimal places while the change claims six.
Model/Type/Product.php	378	weight is not a valid property of OfferShippingDetails, so consumers will not receive a schema-valid shipping weight.

Files Reviewed (1 file)

• Model/Type/Product.php - 3 issues

Fix these issues in Kilo Cloud

---

_{Reviewed by gpt-5.6-luna · Input: 30 · Output: 9.3K · Cached: 234.2K}

[davidwindell]

Should this be using QuantitativeValue? i.e. something like:

if ($product->getWeight() !== null && $product->getWeight() !== '') {
    $data['shippingDetails'] = [
        '@type' => 'OfferShippingDetails',
        'weight' => [
            '@type' => 'QuantitativeValue',
            'value' => (float)$product->getWeight(),
            'unitText' => $this->getConfig('general/locale/weight_unit')
        ]
    ];
}

[Andrew998]

I don't believe so. I have been using it as it is for 6 months now and Google Merchant Centre now lists all products as fully approved without having to provide a feed. Without this addition, they are not fully approved.

[davidwindell]

The official spec claims it is required, so it would be best to migrate to that format.

https://schema.org/OfferShippingDetails

Please also add the same check used elsewhere to gate this logic:

if ($this->getConfig('structureddata/product/include_weight')) {

Then this should be good for merge.

[Andrew998]

Thank you. I will do some further testing and check it all works.