Advanture theme fix - #31
Open
Danielg212 wants to merge 92 commits into
Open
Conversation
Danielgi
- adding few assets to work with
horizontal scrolling levels design
- add scroll position
- creating first template to our figure.
- making moving clouds scale with the screen. - adding the scrool size of the window (for objects starting position)
- code review fixes - moving all scss to live with their component - splitiing work between members
basics clouds + parallax background + Utils.ts
Danielgi
City background
- Adding some objects to language section
contact night theme + day-night transition
contact links aligned to the rest of the texts. +contact picture wrapped
contact title+
background transition with mountains
Danielgi
added preview.png thumbnail
…-doom into danielgi # Conflicts: # package-lock.json # src/index.scss # src/skins/Adventure/Adventure.scss # src/skins/Adventure/Adventure.tsx # src/skins/Adventure/assets/styles/styles.scss # src/skins/Adventure/components/Basics/Basics.scss # src/skins/Adventure/components/Content/Contact.scss # src/skins/Adventure/components/Education/Education.scss # src/skins/Adventure/components/Figure/Figure.scss # src/skins/Adventure/components/Figure/Figure.tsx # src/skins/Adventure/components/Floor/Floor.scss # src/skins/Adventure/components/Language/Language.scss # src/skins/Adventure/components/Skills/Skills.scss # src/skins/Adventure/components/Work/Work.scss # src/skins/Adventure/components/Work/Work.tsx # src/skins/Adventure/manifest.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is the fix for #30 bug