Fixes for Django 3#31
Open
darkman66 wants to merge 1 commit into
Open
Conversation
|
This looks like the fix that i need |
Julio0250
approved these changes
Apr 20, 2020
Julio0250
left a comment
Julio0250
left a comment
There was a problem hiding this comment.
Yesterday I made the same changes because reverse is not declared when evaluate the version of django if u use django 3. This package also works en python 3.4+
|
@ouhouhsami please merge this change! |
henri-hulski
reviewed
Feb 9, 2022
|
|
||
| if DJANGO_VERSION[0] == 2: | ||
|
|
||
| if DJANGO_VERSION[0] in (2, 3): |
There was a problem hiding this comment.
To support also Django 4+ just use:
if DJANGO_VERSION[0] == 1:
from django.core.urlresolvers import reverse
else:
from django.urls import reverse
henri-hulski
reviewed
Feb 9, 2022
| Requirements : | ||
| * Django 1.7.4 or above. | ||
| * Django 1.7.4 or above. (also 3.x) | ||
| * Python 2.7 or 3.4 |
There was a problem hiding this comment.
Python 2.7 or 3.4+ should be fine and Django 4 either.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.