AO3-7406 Move gift exchange notifications to GiftExchangeMailer#5797
AO3-7406 Move gift exchange notifications to GiftExchangeMailer#5797Smuzzy-waiii wants to merge 4 commits intootwcode:masterfrom
Conversation
The following notifications have been moved: - assignments_sent_notification - assignment_default_notification - invalid_signup_notification - potential_match_generation_notification
|
@slavalamp I don't have Jira perms as a first time contributor, could you please set the ticket to In-Progress? 😄 |
…n spec fix: move gift exchange notification calls to right mailer in spec Move calls to gift exchange notification functions in spec/mailers/gift_exchange_mailer_spec.rb to be called under GiftExchangeMailer and not UserMailer, which is what was happening due to previous buggy commit(s)
|
hi, thanks for making this pr (and for fixing the url comments for my mailer previews)! i've set the jira issue to "in review" since that's what an "in progress" status gets automatically changed to when you submit a pr. if it's not ready to be reviewed yet, you should be able to mark this pr as a draft i've only briefly looked through your changes for now, so just letting you know that you can use i18n-tasks to see why the i18n test failed, and you still have leftover also you can check that "have you added tests" checkmark - you're not adding anything new here, but you are updating the tests so they can test the changes you're making |
Remove duplicate gift exchange notifications from UserMailer (app/mailers/user_mailer.rb): - invalid_signup_notification - potential_match_generation_notification
|
Hi @slavalamp! Thank you so much for your quick help and guidance I have removed the leftover Please do let me know if there is anything else needed from my side, including any steps I need to take to get access to Jira (if that is needed at this stage) |
Pull Request Checklist
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing)until they are reviewed and merged before creating new pull requests.
Issue
https://otwarchive.atlassian.net/browse/AO3-7406
Purpose
This PR moves the following notifications related to gift exchange from
UserMailertoGiftExchangeMailer:Credit
Smaran Jawalkar (he/him)