Skip to content

AO3-7406 Move gift exchange notifications to GiftExchangeMailer#5797

Open
Smuzzy-waiii wants to merge 4 commits intootwcode:masterfrom
Smuzzy-waiii:AO3-7406_move_gift_exchange_notifs_to_gift_exchange_mailer
Open

AO3-7406 Move gift exchange notifications to GiftExchangeMailer#5797
Smuzzy-waiii wants to merge 4 commits intootwcode:masterfrom
Smuzzy-waiii:AO3-7406_move_gift_exchange_notifs_to_gift_exchange_mailer

Conversation

@Smuzzy-waiii
Copy link
Copy Markdown

@Smuzzy-waiii Smuzzy-waiii commented May 9, 2026

Pull Request Checklist

Issue

https://otwarchive.atlassian.net/browse/AO3-7406

Purpose

This PR moves the following notifications related to gift exchange from UserMailer to GiftExchangeMailer:

  • assignments_sent_notification
  • assignment_default_notification
  • invalid_signup_notification
  • potential_match_generation_notification

Credit

Smaran Jawalkar (he/him)

The following notifications have been moved:
- assignments_sent_notification
- assignment_default_notification
- invalid_signup_notification
- potential_match_generation_notification
@Smuzzy-waiii
Copy link
Copy Markdown
Author

@slavalamp I don't have Jira perms as a first time contributor, could you please set the ticket to In-Progress? 😄

…n spec

fix: move gift exchange notification calls to right mailer in spec

Move calls to gift exchange notification functions in spec/mailers/gift_exchange_mailer_spec.rb to be called under GiftExchangeMailer and not UserMailer, which is what was happening due to previous buggy commit(s)
@slavalamp
Copy link
Copy Markdown
Contributor

slavalamp commented May 10, 2026

hi, thanks for making this pr (and for fixing the url comments for my mailer previews)!

i've set the jira issue to "in review" since that's what an "in progress" status gets automatically changed to when you submit a pr. if it's not ready to be reviewed yet, you should be able to mark this pr as a draft

i've only briefly looked through your changes for now, so just letting you know that you can use i18n-tasks to see why the i18n test failed, and you still have leftover invalid_signup_notification and potential_match_generation_notification methods in the user mailer. let me know if you need help with anything else here

also you can check that "have you added tests" checkmark - you're not adding anything new here, but you are updating the tests so they can test the changes you're making

Remove duplicate gift exchange notifications from UserMailer (app/mailers/user_mailer.rb):
- invalid_signup_notification
- potential_match_generation_notification
@Smuzzy-waiii
Copy link
Copy Markdown
Author

Smuzzy-waiii commented May 10, 2026

Hi @slavalamp! Thank you so much for your quick help and guidance

I have removed the leftover invalid_signup_notification and potential_match_generation_notification methods in the user mailer. Turns out that is what was causing the i18n tests to fail too

Please do let me know if there is anything else needed from my side, including any steps I need to take to get access to Jira (if that is needed at this stage)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants