fix: handle slow_down error during device auth (closes #438) - #441
Open
botbikamordehai2-sketch wants to merge 1 commit into
Open
fix: handle slow_down error during device auth (closes #438)#441botbikamordehai2-sketch wants to merge 1 commit into
botbikamordehai2-sketch wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
When running
tiddl auth login, the authentication polling loop crashes with an unhandledAuthClientErrorif the Tidal API returns aslow_downerror (or any other unexpected error). The traceback points toget_auth()in the polling loop.Fix
Add explicit handling for the
slow_downerror, which instructs the client to increase the polling interval by 5 seconds and continue waiting. Also added a fallback handler for any unexpectedAuthClientErrorto print an error message and exit gracefully instead of crashing.Closes #438}