Replace static→instance copy ritual with applyStatics helper#30
Merged
Conversation
The base classes for Spell, DamageEffect, DoT, and HOT each repeated a 5–7 line constructor that mirrored static config onto the instance. RenewHOT had its own inline copy of the same shape. One small helper in utils.ts captures the pattern, so subclasses can be pure data: see RenewHOT shedding its constructor entirely. Behavior is unchanged — balance edits still only affect newly spawned attacks (the snapshot semantics live in applyStatics now).
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
balancemender | 6399cfe | Commit Preview URL Branch Preview URL |
May 12 2026, 11:53 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The base classes for Spell, DamageEffect, DoT, and HOT each repeated a
5–7 line constructor that mirrored static config onto the instance.
RenewHOT had its own inline copy of the same shape. One small helper in
utils.ts captures the pattern, so subclasses can be pure data: see
RenewHOT shedding its constructor entirely.
Behavior is unchanged — balance edits still only affect newly spawned
attacks (the snapshot semantics live in applyStatics now).