Pin the osbuild-composer commit for testing#535
Open
achilleas-k wants to merge 7 commits into
Open
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Member
Author
F-X64
previously approved these changes
Mar 18, 2026
Collaborator
F-X64
left a comment
F-X64
left a comment
There was a problem hiding this comment.
I'm in favor of fixing the version.
I assume we will have an automatic PR as we do with the schutzfile?
Member
Author
Not yet, but I'll set it up. |
Member
Author
|
Actually, let me just add the scheduled job in this PR. No need to do it elsewhere. |
achilleas-k
force-pushed
the
pin-composer
branch
from
abb8d38 to
09a5bb2
Compare
Member
Author
|
Added script and action. |
thozza
reviewed
Mar 30, 2026
Member
thozza
left a comment
thozza
left a comment
There was a problem hiding this comment.
In general, this looks good, but there are some copy&paste errors.
achilleas-k
force-pushed
the
pin-composer
branch
from
09a5bb2 to
537d0aa
Compare
Member
Author
|
Thanks for catching those. Fixed and rebased. |
Pin the osbuild-composer commit to use so that it doesn't float and cause unexpected failures.
When deploying, read the commit ID from the Schutzfile to set up the osbuild-composer repository.
Adapted from the osbuild update script in osbuild/images [1]. Unlike the existing function in deploy.sh, it doesn't check for successful CI runs on the commit. It simply makes sure it doesn't use a post-release version bump commit (which don't run CI). Failed CI runs in osbuild-composer often happen after the RPM build stage and we only care about RPMs being available. Skipping a commit based on the overall GitLab CI run would skip over many valid commits. Cases where the PR is created pointing to a commit that doesn't have an RPM for a specific distro we need here can be dealt with manually (usually by retrying the CI job on the main branch of osbuild-composer). [1] https://github.com/osbuild/images/blob/8d0c776c4bf8687f413f3fcac2e28625bba2ce18/test/scripts/update-schutzfile-osbuild
Add a workflow that runs every Sunday to update the osbuild-composer commit ID in the Schutzfile.
New runners are needed for gitlab.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pin the osbuild-composer commit to use so that it doesn't float and cause unexpected failures.
We will later add a cronjob to update the commit regularly, like we do with osbuild.