Adding testing script/environment#18
Open
joshuawills wants to merge 3 commits into
Open
Conversation
edy131109
suggested changes
Jan 4, 2024
edy131109
left a comment
edy131109
left a comment
There was a problem hiding this comment.
That looks great but please don't commit out, out.asm and out.o.
Author
|
Good shout, have removed |
|
Would it not be worth adding files such as |
That would be something @orosmatthew could add in the next video. You could suggest it in a new issue |
|
Submit your pull request to my fork ApplePieCodes/hydrogen-cpp. The original seems to have stopped accepting them |
timomen
approved these changes
Oct 20, 2025
timomen
left a comment
timomen
left a comment
There was a problem hiding this comment.
Nice, also good for other people when they clone it and want to make changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I created a simple test script that you could use to automate testing, ensuring you don't make any breaking changes etc. Checks both exit code and (optionally) stdout when you get to that stage.