Add recovery target reached hook with stop-boundary metadata PG17#63
Closed
GremSnoort wants to merge 4 commits into
Closed
Add recovery target reached hook with stop-boundary metadata PG17#63GremSnoort wants to merge 4 commits into
GremSnoort wants to merge 4 commits into
Conversation
Add a new RecoveryTargetReachedHook for extensions. The hook is invoked after PostgreSQL reaches a recovery target and before recovery_target_action is applied. It receives a RecoveryTargetReachedInfo structure with the target type, stop metadata, and the ReadRecPtr/EndRecPtr of the record at the stop boundary. This gives extensions an explicit recovery stop-boundary context for synchronizing or finalizing custom replay state before PostgreSQL exposes the target-reached state.
pashkinelfe
reviewed
Apr 23, 2026
| * Resource Managers may choose to do permanent corrective actions | ||
| * at end of recovery. | ||
| */ | ||
| recoveryTargetReachedInfo.recoveryTarget = recoveryTarget; |
Contributor
There was a problem hiding this comment.
I propose to remove variables declared as extern from the recoveryTargetReachedInfo struct as they are acessible by Orioledb anyway
pashkinelfe
reviewed
Apr 27, 2026
| * Resource Managers may choose to do permanent corrective actions | ||
| * at end of recovery. | ||
| */ | ||
| recoveryTargetReachedInfo.recoveryTarget = recoveryTarget; |
Contributor
There was a problem hiding this comment.
Also all these assignments are no-op if RecoveryTargetReachedHook == NULL. I propose to move remaining assingments into if block below
|
|
||
| if (reachedRecoveryTarget) | ||
| { | ||
| RecoveryTargetReachedInfo recoveryTargetReachedInfo; |
Contributor
There was a problem hiding this comment.
I propose to move this into if block: if (RecoveryTargetReachedHook != NULL)
| recoveryTargetReachedInfo.recoveryStopXid = recoveryStopXid; | ||
| recoveryTargetReachedInfo.recoveryStopTime = recoveryStopTime; | ||
| recoveryTargetReachedInfo.recoveryStopLSN = recoveryStopLSN; | ||
| recoveryTargetReachedInfo.recoveryStopName = |
Contributor
There was a problem hiding this comment.
Unused in hook, to remove
| */ | ||
| recoveryTargetReachedInfo.recoveryStopAfter = recoveryStopAfter; | ||
| recoveryTargetReachedInfo.recoveryStopXid = recoveryStopXid; | ||
| recoveryTargetReachedInfo.recoveryStopTime = recoveryStopTime; |
Contributor
There was a problem hiding this comment.
Unused in hook, to remove
GremSnoort
changed the title
pashkinelfe
reviewed
Apr 29, 2026
Contributor
pashkinelfe
left a comment
pashkinelfe
left a comment
There was a problem hiding this comment.
After removing duplicate comments, squashing and adding commit message, PR is ready to merge
| } RecoveryTargetReachedInfo; | ||
|
|
||
| /* | ||
| * Hook for extensions to synchronize or finalize custom replay state after |
Contributor
There was a problem hiding this comment.
Duplicate comment, see R114
Contributor
|
Applied proposed edits, squashed, and merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a new
RecoveryTargetReachedHookthat is invoked after PostgreSQL has determined that a recovery target has been reached, but beforerecovery_target_actionis applied.The hook receives explicit stop-boundary metadata via
RecoveryTargetReachedInfo, including:before/after)xid,time,LSN,name)ReadRecPtr/EndRecPtrfor the record at the stop boundaryProblem
PostgreSQL can reach a recovery target before an extension with custom replay/finalization logic has fully synchronized its own visible state to that same stop boundary.
In such cases, PostgreSQL already considers the target reached, but the extension-visible state may still lag behind the actual recovery stop point. This makes it difficult for extensions to guarantee correct target-point visibility semantics using only generic replay-progress information.
Motivation
Extensions with custom replay/finalization logic may need to synchronize their internal state against the actual recovery stop boundary before PostgreSQL exposes the target-reached state.
A generic replay-progress pointer is not always sufficient for this, especially for target types where extension-visible state must match the precise stop boundary semantics.
Changes
RecoveryTargetReachedInfoto carry recovery stop-boundary metadataRecoveryTargetReachedHookTypeRecoveryTargetReachedHookPerformWalRecovery()afterreachedRecoveryTargetand beforerecovery_target_actionis appliedResult
This gives extensions an explicit integration point for target-boundary synchronization/finalization without changing normal replay flow.
Issue
Closes: orioledb/orioledb#820