fix a bug that use a not exist field - #887
Merged
Merged
Conversation
…leases/latest for GitHub, explicit desc sort for Gitee/GitCode, sleep throttle
TRebirthC
changed the title
TRebirthC
force-pushed
the
feat/add-latest-release-date
branch
from
June 22, 2026 04:15
56cddc1 to
58e332c
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Jiannan-dev
reviewed
Jun 22, 2026
Jiannan-dev
left a comment
Jiannan-dev
left a comment
Collaborator
There was a problem hiding this comment.
Inline code review for PR #887.
|
|
||
| const projects = await ViewProjects.findAll({ | ||
| where, | ||
| where: onlyNull ? { latestReleasePublishedAt: null } : undefined, |
Collaborator
There was a problem hiding this comment.
🟡 risk: dropping dataType fixes the bad model field, but this now relies on view_projects permanently enforcing data_type = 1. Add a short code comment or regression test so future view changes do not make onlyNull=false sync non-primary projects.
Jiannan-dev
reviewed
Jun 22, 2026
Jiannan-dev
left a comment
Jiannan-dev
left a comment
Collaborator
There was a problem hiding this comment.
Additional inline code review for PR #887.
| @@ -249,13 +249,8 @@ export async function syncAllProjectReleaseHandler(req, res) { | |||
| const offset = Number(req.body?.offset) || 0; | |||
Collaborator
There was a problem hiding this comment.
🟡 risk: offset accepts negative request values and passes them to Sequelize. Clamp to >= 0 before querying.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix a bug that use a not exist field