Skip to content

Improve AgentSpec component loading defaults#178

Merged
dhilloulinoracle merged 6 commits into
mainfrom
improve-agentspec-component-loading-defaults
May 11, 2026
Merged

Improve AgentSpec component loading defaults#178
dhilloulinoracle merged 6 commits into
mainfrom
improve-agentspec-component-loading-defaults

Conversation

@ljupche98
Copy link
Copy Markdown
Member

@ljupche98 ljupche98 commented May 6, 2026

No description provided.

@ljupche98 ljupche98 self-assigned this May 6, 2026
@ljupche98 ljupche98 requested a review from a team May 6, 2026 13:08
@oracle-contributor-agreement oracle-contributor-agreement Bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label May 6, 2026
@ljupche98 ljupche98 force-pushed the improve-agentspec-component-loading-defaults branch 2 times, most recently from 2a4b264 to 9993869 Compare May 6, 2026 15:17
cesarebernardis
cesarebernardis reviewed May 7, 2026
View reviewed changes
Comment thread docs/pyagentspec/source/changelog.rst Outdated
Comment thread docs/pyagentspec/source/security.rst Outdated
Comment thread pyagentspec/src/pyagentspec/adapters/langgraph/agentspecloader.py Outdated
Comment thread pyagentspec/src/pyagentspec/serialization/componentpolicy.py Outdated
Comment thread pyagentspec/src/pyagentspec/serialization/componentpolicy.py
Comment thread pyagentspec/src/pyagentspec/adapters/_agentspecloader.py Outdated
Comment thread pyagentspec/src/pyagentspec/serialization/deserializer.py Outdated
Comment thread pyagentspec/src/pyagentspec/serialization/deserializer.py Outdated
Comment thread pyagentspec/src/pyagentspec/serialization/deserializer.py Outdated
Comment thread pyagentspec/tests/test_agentspecloader_stdio.py
@dhilloulinoracle
Copy link
Copy Markdown
Contributor

dhilloulinoracle commented May 7, 2026

Internal regression succeeded 🍏: Build ID #441

sonleoracle
sonleoracle approved these changes May 7, 2026
View reviewed changes
Comment thread pyagentspec/src/pyagentspec/adapters/langgraph/agentspecloader.py Outdated
Comment thread pyagentspec/src/pyagentspec/serialization/deserializationcontext.py
Comment thread pyagentspec/src/pyagentspec/serialization/deserializationcontext.py
@ljupche98 ljupche98 force-pushed the improve-agentspec-component-loading-defaults branch from 9993869 to a4ba6ec Compare May 7, 2026 12:18
dhilloulinoracle
dhilloulinoracle reviewed May 7, 2026
View reviewed changes
Comment thread pyagentspec/src/pyagentspec/adapters/crewai/agentspecloader.py
dhilloulinoracle
dhilloulinoracle reviewed May 7, 2026
View reviewed changes
Comment thread pyagentspec/src/pyagentspec/serialization/deserializer.py
dhilloulinoracle
dhilloulinoracle reviewed May 7, 2026
View reviewed changes
Comment thread pyagentspec/src/pyagentspec/component.py
dhilloulinoracle
dhilloulinoracle reviewed May 7, 2026
View reviewed changes
Comment thread pyagentspec/src/pyagentspec/component.py
dhilloulinoracle
dhilloulinoracle reviewed May 7, 2026
View reviewed changes
Comment thread pyagentspec/src/pyagentspec/component.py
@dhilloulinoracle
Copy link
Copy Markdown
Contributor

dhilloulinoracle commented May 7, 2026

Looks like you are considering the class hierarchy.
What happens in those cases:

  • allow LLM (parent class), block OpenAI?
  • block LLM (parent class), allow OpenAI?

I think ideally it should find the most precise rule (sub class) and use that.

Behavior in those cases should be documented in the different docstrings.
We should test the chosen behavior

@ljupche98 ljupche98 force-pushed the improve-agentspec-component-loading-defaults branch from a4ba6ec to e2dc6e6 Compare May 7, 2026 13:52
@ljupche98
Copy link
Copy Markdown
Member Author

ljupche98 commented May 7, 2026

Looks like you are considering the class hierarchy. What happens in those cases:

  • allow LLM (parent class), block OpenAI?
  • block LLM (parent class), allow OpenAI?

I think ideally it should find the most precise rule (sub class) and use that.

Behavior in those cases should be documented in the different docstrings. We should test the chosen behavior

@dhilloulinoracle I updated the logic to consider the most precise rule. With the latest changes:

  • allow LLM (parent class), block OpenAI: OpenAI is blocked
  • block LLM (parent class), allow OpenAI: OpenAI is allowed

cesarebernardis
cesarebernardis reviewed May 7, 2026
View reviewed changes
Comment thread pyagentspec/src/pyagentspec/adapters/langgraph/agentspecloader.py Outdated
cesarebernardis
cesarebernardis reviewed May 7, 2026
View reviewed changes
Comment thread pyagentspec/src/pyagentspec/serialization/deserializationcontext.py Outdated
@ljupche98 ljupche98 force-pushed the improve-agentspec-component-loading-defaults branch 2 times, most recently from 654b103 to 0855250 Compare May 7, 2026 16:25
@dhilloulinoracle
Copy link
Copy Markdown
Contributor

dhilloulinoracle commented May 7, 2026

Merge Gate INPROGRESS

@dhilloulinoracle
Copy link
Copy Markdown
Contributor

dhilloulinoracle commented May 7, 2026

Internal regression failed: Build ID #467

@dhilloulinoracle
Copy link
Copy Markdown
Contributor

dhilloulinoracle commented May 7, 2026

Merge Gate failed: Build ID #675

@ljupche98 ljupche98 force-pushed the improve-agentspec-component-loading-defaults branch from 0855250 to b2edc06 Compare May 7, 2026 16:37
@dhilloulinoracle
Copy link
Copy Markdown
Contributor

dhilloulinoracle commented May 8, 2026

Merge Gate INPROGRESS

@dhilloulinoracle
Copy link
Copy Markdown
Contributor

dhilloulinoracle commented May 8, 2026

Internal regression failed: Build ID #485

@dhilloulinoracle
Copy link
Copy Markdown
Contributor

dhilloulinoracle commented May 8, 2026

Merge Gate failed: Build ID #694

@dhilloulinoracle
Copy link
Copy Markdown
Contributor

dhilloulinoracle commented May 9, 2026

Merge Gate INPROGRESS

@dhilloulinoracle
Copy link
Copy Markdown
Contributor

dhilloulinoracle commented May 9, 2026

Internal regression failed: Build ID #486

@dhilloulinoracle
Copy link
Copy Markdown
Contributor

dhilloulinoracle commented May 9, 2026

Merge Gate failed: Build ID #695

@dhilloulinoracle
Copy link
Copy Markdown
Contributor

dhilloulinoracle commented May 9, 2026

Merge Gate INPROGRESS

@dhilloulinoracle
Copy link
Copy Markdown
Contributor

dhilloulinoracle commented May 9, 2026

Internal regression failed: Build ID #487

@dhilloulinoracle
Copy link
Copy Markdown
Contributor

dhilloulinoracle commented May 9, 2026

Merge Gate failed: Build ID #696

@dhilloulinoracle
Copy link
Copy Markdown
Contributor

dhilloulinoracle commented May 9, 2026

Merge Gate INPROGRESS

@dhilloulinoracle
Copy link
Copy Markdown
Contributor

dhilloulinoracle commented May 9, 2026

Internal regression failed: Build ID #488

@dhilloulinoracle
Copy link
Copy Markdown
Contributor

dhilloulinoracle commented May 9, 2026

Merge Gate failed: Build ID #697

@dhilloulinoracle
Copy link
Copy Markdown
Contributor

dhilloulinoracle commented May 9, 2026

Merge Gate INPROGRESS

@dhilloulinoracle
Copy link
Copy Markdown
Contributor

dhilloulinoracle commented May 9, 2026

Internal regression failed: Build ID #489

@dhilloulinoracle
Copy link
Copy Markdown
Contributor

dhilloulinoracle commented May 9, 2026

Merge Gate failed: Build ID #698

@dhilloulinoracle
Copy link
Copy Markdown
Contributor

dhilloulinoracle commented May 9, 2026

Merge Gate INPROGRESS

@dhilloulinoracle
Copy link
Copy Markdown
Contributor

dhilloulinoracle commented May 9, 2026

Internal regression failed: Build ID #490

@dhilloulinoracle
Copy link
Copy Markdown
Contributor

dhilloulinoracle commented May 9, 2026

Merge Gate failed: Build ID #699

@dhilloulinoracle
Copy link
Copy Markdown
Contributor

dhilloulinoracle commented May 9, 2026

Merge Gate INPROGRESS

@dhilloulinoracle
Copy link
Copy Markdown
Contributor

dhilloulinoracle commented May 9, 2026

Internal regression failed: Build ID #491

@dhilloulinoracle
Copy link
Copy Markdown
Contributor

dhilloulinoracle commented May 9, 2026

Merge Gate failed: Build ID #700

@dhilloulinoracle
Copy link
Copy Markdown
Contributor

dhilloulinoracle commented May 11, 2026

Merge Gate INPROGRESS

@dhilloulinoracle
Copy link
Copy Markdown
Contributor

dhilloulinoracle commented May 11, 2026

Internal regression failed: Build ID #492

@dhilloulinoracle
Copy link
Copy Markdown
Contributor

dhilloulinoracle commented May 11, 2026

Merge Gate failed: Build ID #701

@dhilloulinoracle
Copy link
Copy Markdown
Contributor

dhilloulinoracle commented May 11, 2026

Merge Gate INPROGRESS

@dhilloulinoracle
Copy link
Copy Markdown
Contributor

dhilloulinoracle commented May 11, 2026

Internal regression succeeded 🍏: Build ID #493

@dhilloulinoracle dhilloulinoracle merged commit c0f1288 into main May 11, 2026
6 of 7 checks passed
@dhilloulinoracle
Copy link
Copy Markdown
Contributor

dhilloulinoracle commented May 11, 2026

Merge Gate succeeded 🍏: Build ID #702

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cesarebernardis cesarebernardis cesarebernardis approved these changes

@dhilloulinoracle dhilloulinoracle dhilloulinoracle approved these changes

@sonleoracle sonleoracle sonleoracle approved these changes

Assignees

@ljupche98 ljupche98

Labels

OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ljupche98 @dhilloulinoracle @cesarebernardis @sonleoracle