IHS-88: Fix sync_with_git default, set to False#1025
Open
solababs wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## stable #1025 +/- ##
=======================================
Coverage 81.54% 81.54%
=======================================
Files 134 134
Lines 11467 11467
Branches 1735 1735
=======================================
Hits 9351 9351
Misses 1569 1569
Partials 547 547
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
ajtmccarty
approved these changes
May 15, 2026
Contributor
ajtmccarty
left a comment
There was a problem hiding this comment.
I think this is technically a breaking change, so would be good to make that a little more clear in the changelog. in the infrahub release notes we have a Breaking Changes section for a release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
client.branch.create()defaultedsync_with_gittoTrue, while the UI and theinfrahubctl branch createCLI both default toFalse.This PR aligns the programmatic SDK API with the UI default.
Closes #224
What changed
InfrahubBranchManager.create()andInfrahubBranchManagerSync.create()now defaultsync_with_gittoFalse. Callers that already pass the argument explicitly are unaffected.Impact & rollout
Truedefault. Changelog entry added (changelog/224.changed.md).Checklist
changelog/224.changed.md)Summary by cubic
Aligns SDK branch creation default with the UI and CLI by setting
sync_with_gitto False. Addresses IHS-88 and prevents unexpected Git syncs when creating branches via the SDK.Bug Fixes
sync_with_git=FalseinInfrahubBranchManager.create()andInfrahubBranchManagerSync.create().Migration
Truedefault, passsync_with_git=Trueexplicitly.Written for commit 876c9d0. Summary will update on new commits.