[codex] migrate generator to direct g4 input - #1
Draft
tinovyatkin wants to merge 3 commits into
Draft
Conversation
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
tinovyatkin
force-pushed
the
codex/issue-141-direct-g4
branch
from
July 22, 2026 14:19
af80b91 to
493aa48
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Gremlin.g4GremlinParsermodule andParsedFileAPIophi-dev/antlr-rust-runtime@c31ce00172d7a38b14dc991878caab810c40148fWhy
This is the gremlin-rs integration branch for
ophi-dev/antlr-rust-runtime#141. It exercises a large combined grammar and the intentional generated parser naming change against the exact Phase C runtime candidate.Impact
Parser regeneration no longer requires Java, the ANTLR tool jar, or
.interpmetadata. Existing parse entry points retain their behavior while returning the runtime's pairedParsedFilerepresentation.Validation
cargo test --locked --all-features(unit, integration, and doctests)cargo clippy --locked --all-targets --all-features -- -D warningscargo fmt --all -- --checkgrammar/Gremlin.g4produced no drift at the final runtime pin