fix: remove invalid <descriptions> from DMN files, add bpmn: prefix t…#25
Merged
Conversation
…o xsi:type <descriptions> is not a valid DMN 1.3 element and causes a SAXException on deployment in Operaton 2.1.2. Remove it from credit-decision.dmn, purchase-requisition-routing.dmn, claim-settlement.dmn, risk-assessment.dmn. xsi:type="tFormalExpression" (unqualified) fails schema validation in the updated engine; change to xsi:type="bpmn:tFormalExpression" in loan-application.bpmn, incident-management.bpmn, order-fulfillment.bpmn. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018MQnsh6ZTicNjjhccHMwuh
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses XML schema-validation problems in Operaton 2.1.2 by removing invalid DMN <descriptions> elements and qualifying unprefixed BPMN xsi:type values so deployments no longer fail with SAX/schema validation errors.
Changes:
- Removed invalid
<descriptions>blocks from several DMN 1.3 models. - Updated BPMN conditional/timer expressions to use
xsi:type="bpmn:tFormalExpression"where needed. - Added Maven profiles in
examples/dmn-decisionto auto-adjust Testcontainers environment variables for Rancher Desktop / Colima (note: not mentioned in PR description).
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| examples/use-cases/order-fulfillment/src/main/resources/order-fulfillment.bpmn | Qualifies conditionExpression xsi:type with bpmn: prefix for schema validity. |
| examples/use-cases/loan-application/src/main/resources/risk-assessment.dmn | Removes invalid DMN <descriptions> element to prevent DMN 1.3 parse/validation errors. |
| examples/use-cases/loan-application/src/main/resources/loan-application.bpmn | Qualifies multiple gateway condition expressions with xsi:type="bpmn:tFormalExpression". |
| examples/use-cases/insurance-claim/src/main/resources/claim-settlement.dmn | Removes invalid DMN <descriptions> element. |
| examples/use-cases/incident-management/src/main/resources/incident-management.bpmn | Qualifies condition expressions and timer duration xsi:type with bpmn: prefix. |
| examples/dmn-decision/src/main/resources/credit-decision.dmn | Removes invalid DMN <descriptions> element. |
| examples/dmn-decision/pom.xml | Adds auto-activating Maven profiles that change Testcontainers/Docker environment variables. |
| examples/approval-sla-metrics/src/main/resources/purchase-requisition-routing.dmn | Removes invalid <descriptions> element, leaving a dmn:description entry. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <descriptions>Demonstrates observing a BPMN process in real time: a purchase-requisition | ||
|
|
||
| Copyright 2026 the Operaton contributors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0</descriptions><dmn:description>sds</dmn:description> | ||
| <dmn:description>sds</dmn:description> |
Comment on lines
+98
to
+102
| <profiles> | ||
| <!-- Auto-activates on machines running Rancher Desktop instead of Docker Desktop --> | ||
| <profile> | ||
| <id>docker-alternative-rancher</id> | ||
| <activation> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…o xsi:type
is not a valid DMN 1.3 element and causes a SAXException on deployment in Operaton 2.1.2. Remove it from credit-decision.dmn, purchase-requisition-routing.dmn, claim-settlement.dmn, risk-assessment.dmn.
xsi:type="tFormalExpression" (unqualified) fails schema validation in the updated engine; change to xsi:type="bpmn:tFormalExpression" in loan-application.bpmn, incident-management.bpmn, order-fulfillment.bpmn.
Claude-Session: https://claude.ai/code/session_018MQnsh6ZTicNjjhccHMwuh