exec: harden deferred reply teardown#32
Open
wildmeng wants to merge 1 commit into
Open
Conversation
Avoid scheduling another deferred exec reply once reply teardown has started and keep the first scheduled deferred status while a reply callback is pending. Also handle blob allocation failures in the async exec/plugin reply path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #27.
The deferred async exec reply path can still schedule another zero-timeout reply once reply teardown has started. On current master this path reuses
c->timeout, so leave teardown marked by clearingtimeout.cband keep the first pending deferred status while a reply callback is already queued.Also initialize the exec reply blob buffer before pipe/fork cleanup paths and guard plugin JSON table/array allocation failures before closing or recursing into them.