Skip to content

xinetd: fix bad printf formats#17748

Merged
feckert merged 1 commit into
openwrt:masterfrom
neheb:8
Feb 3, 2022
Merged

xinetd: fix bad printf formats#17748
feckert merged 1 commit into
openwrt:masterfrom
neheb:8

Conversation

@neheb

@neheb neheb commented Jan 31, 2022

Copy link
Copy Markdown
Contributor

Easier to use the proper C macro.

Signed-off-by: Rosen Penev rosenp@gmail.com

Maintainer: @feckert
Compile tested: ppc64

Easier to use the proper C macro.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
@feckert

feckert commented Jan 31, 2022

Copy link
Copy Markdown
Member

LGTM
Should we send this to the upstream project?

@neheb

neheb commented Jan 31, 2022

Copy link
Copy Markdown
Contributor Author

Isn't it dead upstream?

@feckert feckert self-requested a review January 31, 2022 21:53
@BKPepe

BKPepe commented Feb 2, 2022

Copy link
Copy Markdown
Member

Still it should be send to upstream.

@neheb

neheb commented Feb 2, 2022

Copy link
Copy Markdown
Contributor Author

Upstream's last update was in 2016 with pending PRs. I don't think there's a point in trying to upstream.

@BKPepe

BKPepe commented Feb 2, 2022

Copy link
Copy Markdown
Member

Well, atleast while sending to upstream, it is clear who authored it, why the change is required and so on. Then any GNU/Linux distribution can use it or maybe dealing with it, so it is always good idea to send it there even they are not active. Anyone can review it.

@neheb

neheb commented Feb 2, 2022

Copy link
Copy Markdown
Contributor Author

meh alright: xinetd-org/xinetd#35

@feckert feckert merged commit cb47197 into openwrt:master Feb 3, 2022
@neheb neheb deleted the 8 branch February 3, 2022 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants