netifd: configure EEE via ethtool netlink#80
Open
cmonroe wants to merge 1 commit into
Open
Conversation
The legacy ETHTOOL_SEEE ioctl is rejected by phylink-based PHY drivers that only implement the netlink set_eee path. Switch the EEE setter to ETHTOOL_MSG_EEE_SET, falling back to the legacy ioctl when genetlink is unavailable. Expose tx_lpi, tx_lpi_timer, and advertised modes as config device options so the full netlink interface is reachable from UCI. When eee=1 without an explicit eee_advertise list, query the PHY's supported EEE modes via ETHTOOL_MSG_EEE_GET and advertise that set. Send MODES_OURS with NOMASK so the kernel replaces the previously advertised bitmap rather than merging with it. Signed-off-by: Chad Monroe <chad@monroe.io>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The legacy ETHTOOL_SEEE ioctl is rejected by phylink-based PHY drivers that only implement the netlink set_eee path.
Switch the EEE setter to ETHTOOL_MSG_EEE_SET, falling back to the legacy ioctl when genetlink is unavailable. Expose tx_lpi, tx_lpi_timer, and advertised modes as config device options so the full netlink interface is reachable from UCI.
When eee=1 without an explicit eee_advertise list, query the PHY's supported EEE modes via ETHTOOL_MSG_EEE_GET and advertise that set.
Send MODES_OURS with NOMASK so the kernel replaces the previously advertised bitmap rather than merging with it.