Skip to content

fix(sdk): update proto bindings to protocol/go/v0.33.1#948

Merged
eugenioenko merged 1 commit into
mainfrom
DSPX-3613
Jun 17, 2026
Merged

fix(sdk): update proto bindings to protocol/go/v0.33.1#948
eugenioenko merged 1 commit into
mainfrom
DSPX-3613

Conversation

@eugenioenko

@eugenioenko eugenioenko commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Regenerates platform proto bindings against protocol/go/v0.33.1 which includes search/sort/filter types from selectors.proto (PageRequest, PageResponse, Search, per-entity Sort messages)
  • Removes deprecated grpc-gateway proto bindings (google/api, protoc-gen-openapiv2)
  • Squashed from PR fix(sdk): Updates to proto version protocol/go/v0.34.0 #866 (update-platform-protos branch) with SDK adaptation fixes

Breaking proto changes (upstream)

The platform protos introduced a breaking change in protocol/go/v0.33.0 (DSPX-2998: add namespace fields to resource mapping protos):

  • Certificate message removed from policy/objects.proto
  • root_certs field removed from the Namespace message

Web SDK follow-up

  • Removed the getRootCertsFromNamespace function from lib/src/policy/api.ts (it returned Certificate[] from Namespace.rootCerts, both of which no longer exist)
  • Removed the Certificate and GetNamespaceResponse imports that were only used by that function
  • Deleted lib/tests/mocha/policy-api.spec.ts (only tested the removed function)
  • Removed rootCerts: [] from mock Namespace objects in test files (client.spec.ts, kas-key-cache.spec.ts, kas-key-splits.spec.ts, granter.test.ts, mock-attrs.ts)

Test plan

  • CI passes (build, format, tests)
  • DCO check passes
  • Verify generated types include Search, Sort, PageRequest, PageResponse from selectors.proto
  • Smoke test: new types compile and are importable

Closes DSPX-3613 (partial — proto regen portion)

🤖 Generated with Claude Code

Regenerate platform proto bindings against protocol/go/v0.33.1 which
includes search/sort/filter types from selectors.proto (PageRequest,
PageResponse, Search, per-entity Sort messages).

Also removes Certificate type and rootCerts from Namespace, which were
dropped in protocol/go/v0.33.0 (DSPX-2998).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Eugene Yakhnenko <eugene.yakhnenko@virtru.com>
@eugenioenko eugenioenko requested a review from a team as a code owner June 17, 2026 18:54
@coderabbitai

coderabbitai Bot commented Jun 17, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@eugenioenko, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 19 minutes and 44 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: abadb22e-b616-422e-8a2b-5daf934df482

📥 Commits

Reviewing files that changed from the base of the PR and between 04f3ae4 and 80c4e7b.

📒 Files selected for processing (30)
  • lib/platform-proto-version.json
  • lib/src/platform/authorization/authorization_pb.ts
  • lib/src/platform/authorization/v2/authorization_pb.ts
  • lib/src/platform/buf/validate/validate_pb.ts
  • lib/src/platform/entityresolution/entity_resolution_pb.ts
  • lib/src/platform/entityresolution/v2/entity_resolution_pb.ts
  • lib/src/platform/google/api/annotations_pb.ts
  • lib/src/platform/google/api/http_pb.ts
  • lib/src/platform/kas/kas_pb.ts
  • lib/src/platform/policy/actions/actions_pb.ts
  • lib/src/platform/policy/attributes/attributes_pb.ts
  • lib/src/platform/policy/kasregistry/key_access_server_registry_pb.ts
  • lib/src/platform/policy/namespaces/namespaces_pb.ts
  • lib/src/platform/policy/objects_pb.ts
  • lib/src/platform/policy/obligations/obligations_pb.ts
  • lib/src/platform/policy/registeredresources/registered_resources_pb.ts
  • lib/src/platform/policy/resourcemapping/resource_mapping_pb.ts
  • lib/src/platform/policy/selectors_pb.ts
  • lib/src/platform/policy/subjectmapping/subject_mapping_pb.ts
  • lib/src/platform/policy/unsafe/unsafe_pb.ts
  • lib/src/platform/protoc-gen-openapiv2/options/annotations_pb.ts
  • lib/src/platform/protoc-gen-openapiv2/options/openapiv2_pb.ts
  • lib/src/platform/wellknownconfiguration/wellknown_configuration_pb.ts
  • lib/src/policy/api.ts
  • lib/tests/mocha/client.spec.ts
  • lib/tests/mocha/kas-key-cache.spec.ts
  • lib/tests/mocha/kas-key-splits.spec.ts
  • lib/tests/mocha/policy-api.spec.ts
  • lib/tests/web/policy/granter.test.ts
  • lib/tests/web/policy/mock-attrs.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch DSPX-3613

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the platform protocol definitions and client libraries. Key changes include the removal of Google API annotations and OpenAPI v2 options, the introduction of experimental features like DirectEntitlement and HPQT algorithms (such as HPQT_XWING), and the addition of sorting and searching capabilities across various list requests (attributes, namespaces, obligations, registered resources, and subject mappings). Additionally, namespace scoping has been enhanced with namespace ID and FQN fields, the namespace certificate/root certificate model has been removed (along with the getRootCertsFromNamespace helper and its tests), and an allow_traversal option has been added to attributes to support front-loaded TDF creation. There are no review comments, so I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@jakedoublev jakedoublev left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eugenioenko eugenioenko merged commit 19bed9d into main Jun 17, 2026
27 of 28 checks passed
@eugenioenko eugenioenko deleted the DSPX-3613 branch June 17, 2026 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants