Update regex pattern for diseaseFromSourceMappedId#237
Merged
Conversation
ireneisdoomed
approved these changes
Dec 2, 2025
ireneisdoomed
left a comment
ireneisdoomed
left a comment
Contributor
There was a problem hiding this comment.
What's the reason behind this?
Contributor
Author
|
Contributor
|
We decided after the chat with EVA that we wouldn't keep a whitelist of ontologies in the regex. I suggest changing the pattern to: |
DSuveges
force-pushed
the
ds_4104_disease_pattern
branch
from
1db5313 to
ad636fa
Compare
Relaxed pattern of validating the contents of the `diseaseFromSourceMappedId` column.
DSuveges
force-pushed
the
ds_4104_disease_pattern
branch
from
ad636fa to
c8fb7b8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Relaxed pattern for validating the contents of the
diseaseFromSourceMappedIdcolumn. It might not capture all possible problems (eg. not enforces digits in the postfix), but the disease validation downstream takes care about these nuances.