Fix unsafe atoi() usage in get_sock_port()#647
Open
NotUnHackable wants to merge 1 commit into
Open
Conversation
Replace atoi() with strtonum() for safer port number conversion. atoi() has undefined behavior on overflow and no error detection, while strtonum() provides proper bounds validation and error reporting. Reported-by: Security audit
Contributor
|
I'm not sure this is worth fixing. The port string in this case comes from getnameinfo(3), so if it is returning garbage then the system is already hosed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace atoi() with strtonum() for safer port number conversion. atoi() has undefined behavior on overflow and no error detection, while strtonum() provides proper bounds validation and error reporting.