Skip to content

WINC-1968: [ote] Fix OCP-73752 network metric assertion - #4439

Open
rrasouli wants to merge 1 commit into
openshift:masterfrom
rrasouli:winc-1968-fix-73752-metric-assertion
Open

WINC-1968: [ote] Fix OCP-73752 network metric assertion#4439
rrasouli wants to merge 1 commit into
openshift:masterfrom
rrasouli:winc-1968-fix-73752-metric-assertion

Conversation

@rrasouli

@rrasouli rrasouli commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes OCP-73752 OTE test that fails 100% of the time in CI with "Timed out waiting for metric pod:network_receive_bytes_total:sum" after 5 minutes of polling.

Root Cause

The recording rule pod:network_receive_bytes_total:sum does not produce results for the WMCO operator pod because it is a Linux control-plane pod, not a Windows workload pod. The original OTP test only verifies the Prometheus query executes successfully (status=success) without asserting the metric value is non-empty. PR #4429 made the test stricter than the original by adding a non-empty assertion inside a poll loop, which caused the test to time out every run.

Fix

Revert to the original OTP behavior: query Prometheus, assert no error, log the value. Do not require the value to be non-empty.

Testing

  • Compiles and passes gofmt
  • Matches the original OTP test behavior at openshift-tests-private/test/extended/winc/winc.go

The OCP-73752 test was failing because it required non-empty metric
values from pod:network_receive_bytes_total:sum, but this recording
rule does not always produce results for the WMCO operator pod (a
Linux control-plane pod). The original OTP test only verifies the
Prometheus query succeeds without asserting the value is non-empty.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 10, 2026
@openshift-ci-robot

openshift-ci-robot commented Aug 10, 2026

Copy link
Copy Markdown

@rrasouli: This pull request references WINC-1968 which is a valid jira issue.

Details

In response to this:

The OCP-73752 test was failing because it required non-empty metric values from pod:network_receive_bytes_total:sum, but this recording rule does not always produce results for the WMCO operator pod (a Linux control-plane pod). The original OTP test only verifies the Prometheus query succeeds without asserting the value is non-empty.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ci Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rrasouli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 10, 2026
@rrasouli

Copy link
Copy Markdown
Contributor Author

/hold

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 10, 2026
@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (2)
  • do-not-merge/work-in-progress
  • do-not-merge/hold

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 93a9965d-2574-48d9-9793-b50633707721

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants