WINC-1968: [ote] Fix OCP-73752 network metric assertion - #4439
Conversation
The OCP-73752 test was failing because it required non-empty metric values from pod:network_receive_bytes_total:sum, but this recording rule does not always produce results for the WMCO operator pod (a Linux control-plane pod). The original OTP test only verifies the Prometheus query succeeds without asserting the value is non-empty.
|
@rrasouli: This pull request references WINC-1968 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rrasouli The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold |
|
Important Review skippedAuto reviews are limited based on label configuration. 🚫 Review skipped — only excluded labels are configured. (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Fixes OCP-73752 OTE test that fails 100% of the time in CI with "Timed out waiting for metric pod:network_receive_bytes_total:sum" after 5 minutes of polling.
Root Cause
The recording rule
pod:network_receive_bytes_total:sumdoes not produce results for the WMCO operator pod because it is a Linux control-plane pod, not a Windows workload pod. The original OTP test only verifies the Prometheus query executes successfully (status=success) without asserting the metric value is non-empty. PR #4429 made the test stricter than the original by adding a non-empty assertion inside a poll loop, which caused the test to time out every run.Fix
Revert to the original OTP behavior: query Prometheus, assert no error, log the value. Do not require the value to be non-empty.
Testing