[release-4.21] Handle missing sriov_numvfs during Mellanox firmware reset#1240
Open
SchSeba wants to merge 2 commits into
Open
[release-4.21] Handle missing sriov_numvfs during Mellanox firmware reset#1240SchSeba wants to merge 2 commits into
SchSeba wants to merge 2 commits into
Conversation
When running with readOnlyRootFilesystem enabled, mstconfig fails to create its lockfiles because the path /tmp/mstflint_lockfiles is hardcoded in the mstflint source code. This patch adds an emptyDir volume mounted at /tmp to provide a writable location for these lockfiles while maintaining the security benefits of a read-only root filesystem for the rest of the container. Signed-off-by: Fred Rolland <frolland@nvidia.com> (cherry picked from commit 77a9221) Signed-off-by: Sebastian Sch <sebassch@gmail.com>
When SRIOV_EN is false the sriov_numvfs sysfs file does not exist. SetSriovNumVfs now checks for the file before writing and returns success when numVfs is 0 and the file is absent, so callers like MlxResetFW do not need special error handling for this case. Signed-off-by: Sebastian Sch <sebassch@gmail.com> (cherry picked from commit b93b9be) Signed-off-by: Sebastian Sch <sebassch@gmail.com>
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SchSeba The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
Contributor
|
@SchSeba: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sriov_numvfsto0when the sysfs file is not present after staging Mellanox firmware changesSRIOV_ENis still disabled until reboot/tmpformstconfiglockfiles when the config-daemon runs withreadOnlyRootFilesystemTest plan
Made with Cursor