Skip to content

OCPBUGS-87999,OCPBUGS-88000: [release-4.19] Backport Mellanox firmware reset defaults#1233

Open
SchSeba wants to merge 3 commits into
openshift:release-4.19from
SchSeba:cp-release-4.19-20260601
Open

OCPBUGS-87999,OCPBUGS-88000: [release-4.19] Backport Mellanox firmware reset defaults#1233
SchSeba wants to merge 3 commits into
openshift:release-4.19from
SchSeba:cp-release-4.19-20260601

Conversation

@SchSeba

@SchSeba SchSeba commented Jun 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

  • install kmod in the downstream config daemon image so mstfwreset support works with newer mstflint
  • enable MellanoxFirmwareResetFeatureGate by default on release-4.19
  • adapt the older release-4.19 feature-gate implementation so the new default behavior works with the APIs available on that branch

SchSeba added 2 commits June 1, 2026 11:54
@SchSeba
d/s only: install kmod for mstfwreset support
6e64be0 
this is needed when the version of mstfwreset will be >= v4.32

Signed-off-by: Sebastian Sch <sebassch@gmail.com>
@SchSeba
Enable MellanoxFirmwareResetFeatureGate by default
de1dd16 
This feature gate is used to enable the Mellanox firmware reset feature.

The reason we enable this feature gate is because on newer mstflint version
mstconfig command sends MFRL with bit 6 AND bit 3 ((1<<6)|(1<<3)).
some cards like ConnectX-6 Dx firmware does not support the bit 3 (PCIe link toggle) reset trigger for this operation,
so the MFRL SET command fails (rc != 0).
The code returns "Please power cycle machine to load new configurations."

The operator does not have access to out of band management system to make a power cycle.
so instead we run mstfwreset command to reset the firmware.

Signed-off-by: Sebastian Sch <sebassch@gmail.com>
(cherry picked from commit 518df93)
@openshift-ci openshift-ci Bot requested review from dougbtv and kunalmemane June 1, 2026 11:58
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 1, 2026
@SchSeba @cursoragent
Fix release-4.19 feature gate backport
a1270ed 
Limit the default feature-state backport to feature gates that exist on release-4.19 so the branch builds and the Mellanox reset default remains enabled.

Signed-off-by: Sebastian Sch <sebassch@gmail.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@SchSeba SchSeba force-pushed the cp-release-4.19-20260601 branch from f0a1e5d to a1270ed Compare June 9, 2026 11:47
@openshift-ci

openshift-ci Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

@SchSeba: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@SchSeba

SchSeba commented Jun 10, 2026

Copy link
Copy Markdown
Contributor Author

/label backport-risk-assessed

@openshift-ci openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jun 10, 2026
@zeeke

zeeke commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 10, 2026
@openshift-ci

openshift-ci Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SchSeba, zeeke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@SchSeba

SchSeba commented Jun 10, 2026

Copy link
Copy Markdown
Contributor Author

/retitle OCPBUGS-87999,OCPBUGS-88000 [release-4.19] Backport Mellanox firmware reset defaults

@openshift-ci openshift-ci Bot changed the title [release-4.19] Backport Mellanox firmware reset defaults OCPBUGS-87999,OCPBUGS-88000 [release-4.19] Backport Mellanox firmware reset defaults Jun 10, 2026
@SchSeba

SchSeba commented Jun 10, 2026

Copy link
Copy Markdown
Contributor Author

/retitle OCPBUGS-87999 OCPBUGS-88000 [release-4.19] Backport Mellanox firmware reset defaults

@openshift-ci openshift-ci Bot changed the title OCPBUGS-87999,OCPBUGS-88000 [release-4.19] Backport Mellanox firmware reset defaults OCPBUGS-87999 OCPBUGS-88000 [release-4.19] Backport Mellanox firmware reset defaults Jun 10, 2026
@SchSeba

SchSeba commented Jun 10, 2026

Copy link
Copy Markdown
Contributor Author

/jira refresh

@openshift-ci-robot

openshift-ci-robot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

@SchSeba: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@SchSeba

SchSeba commented Jun 10, 2026

Copy link
Copy Markdown
Contributor Author

/retitle OCPBUGS-87999,OCPBUGS-88000: [release-4.19] Backport Mellanox firmware reset defaults

@openshift-ci openshift-ci Bot changed the title OCPBUGS-87999 OCPBUGS-88000 [release-4.19] Backport Mellanox firmware reset defaults OCPBUGS-87999,OCPBUGS-88000: [release-4.19] Backport Mellanox firmware reset defaults Jun 10, 2026
@openshift-ci-robot openshift-ci-robot added the jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. label Jun 10, 2026
@SchSeba

SchSeba commented Jun 10, 2026

Copy link
Copy Markdown
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 10, 2026
@openshift-ci-robot

openshift-ci-robot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

@SchSeba: This pull request references Jira Issue OCPBUGS-87999, which is invalid:

  • expected Jira Issue OCPBUGS-87999 to depend on a bug targeting a version in 4.20.0, 4.20.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

This pull request references Jira Issue OCPBUGS-88000, which is invalid:

  • expected Jira Issue OCPBUGS-88000 to depend on a bug targeting a version in 4.20.0, 4.20.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

  • install kmod in the downstream config daemon image so mstfwreset support works with newer mstflint
  • enable MellanoxFirmwareResetFeatureGate by default on release-4.19
  • adapt the older release-4.19 feature-gate implementation so the new default behavior works with the APIs available on that branch

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot

openshift-ci-robot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

@SchSeba: This pull request references Jira Issue OCPBUGS-87999, which is invalid:

  • expected Jira Issue OCPBUGS-87999 to depend on a bug targeting a version in 4.20.0, 4.20.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

This pull request references Jira Issue OCPBUGS-88000, which is invalid:

  • expected Jira Issue OCPBUGS-88000 to depend on a bug targeting a version in 4.20.0, 4.20.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@SchSeba

SchSeba commented Jun 10, 2026

Copy link
Copy Markdown
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 10, 2026
@openshift-ci-robot

openshift-ci-robot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

@SchSeba: This pull request references Jira Issue OCPBUGS-87999, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.z) matches configured target version for branch (4.19.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-86847 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-86847 targets the "4.20.z" version, which is one of the valid target versions: 4.20.0, 4.20.z
  • bug has dependents

Requesting review from QA contact:
/cc @ajaggapa

This pull request references Jira Issue OCPBUGS-88000, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.z) matches configured target version for branch (4.19.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-86853 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-86853 targets the "4.20.z" version, which is one of the valid target versions: 4.20.0, 4.20.z
  • bug has dependents

Requesting review from QA contact:
/cc @ajaggapa

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot requested a review from ajaggapa June 10, 2026 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dougbtv dougbtv Awaiting requested review from dougbtv
@kunalmemane kunalmemane Awaiting requested review from kunalmemane
@ajaggapa ajaggapa Awaiting requested review from ajaggapa

Assignees

@zeeke zeeke

@kononovn kononovn

@zhiqiangf zhiqiangf

@evgenLevin evgenLevin

@ajaggapa ajaggapa

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@SchSeba @zeeke @openshift-ci-robot @kononovn @zhiqiangf @evgenLevin @ajaggapa