Skip to content

Move tls-scanner-run to post phase with best_effort for opendatahub-o… #82676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
GowthamShanmugam wants to merge 1 commit into from
+2 −0
Closed

Move tls-scanner-run to post phase with best_effort for opendatahub-o… #82676

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .../config/opendatahub-io/opendatahub-operator/opendatahub-io-opendatahub-operator-main.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,9 @@ tests:
cpu: 2000m
memory: 3Gi
timeout: 3h0m0s
post:
- ref: tls-scanner-run
best_effort: true
Comment on lines +161 to +163

@coderabbitai coderabbitai Bot Jul 30, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

make registry-metadata && make ci-operator-config && make jobs

Repository: openshift/release

Length of output: 197

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "== Makefile =="
if [ -f Makefile ]; then
  sed -n '1,220p' Makefile | nl -ba | sed -n '1,220p'
else
  echo "No Makefile at repository root"
fi

echo
echo "== ci-operator config file excerpt =="
FILE="ci-operator/config/opendatahub-io/opendatahub-operator/opendatahub-io-opendatahub-operator-main.yaml"
if [ -f "$FILE" ]; then
  wc -l "$FILE"
  sed -n '130,180p' "$FILE" | nl -ba -v130
else
  echo "Missing $FILE"
fi

echo
echo "== Generated files that may be affected =="
git ls-files | rg 'generated|metadata|prow|jobs|ci-operator|opendatahub-io-opendatahub-operator-main' | sed -n '1,200p'

echo
echo "== Make invocations in git history / current diff =="
git diff --stat || true
git diff -- ci-operator/config/opendatahub-io/opendatahub-operator/opendatahub-io-opendatahub-operator-main.yaml | sed -n '1,220p' || true

Repository: openshift/release

Length of output: 210

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "== Makefile =="
if [ -f Makefile ]; then
  sed -n '1,220p' Makefile
else
  echo "No Makefile at repository root"
fi

echo
echo "== ci-operator config file excerpt =="
FILE="ci-operator/config/opendatahub-io/opendatahub-operator/opendatahub-io-opendatahub-operator-main.yaml"
if [ -f "$FILE" ]; then
  wc -l "$FILE"
  sed -n '130,180p' "$FILE"
else
  echo "Missing $FILE"
fi

echo
echo "== Generated files that may be affected =="
git ls-files | grep -E 'generated|metadata|prow|jobs|ci-operator|opendatahub-io-opendatahub-operator-main' | sed -n '1,200p'

echo
echo "== Diff for target file =="
git diff -- ci-operator/config/opendatahub-io/opendatahub-operator/opendatahub-io-opendatahub-operator-main.yaml | sed -n '1,260p' || true

echo
echo "== Target workflow/config references =="
python3 - <<'PY'
from pathlib import Path
for p in list(Path('.').glob('**/*'))[:20]:
    pass
print("Python available")
PY

Repository: openshift/release

Length of output: 30176

Regenerate the downstream CI artifacts for this ci-operator change.

ci-operator/config/ changes are the source of truth for generated metadata/Prow jobs. Run the repo’s generation target, e.g. make update (or make jobs ci-operator-config registry-metadata), and commit any generated diffs before merge.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@ci-operator/config/opendatahub-io/opendatahub-operator/opendatahub-io-opendatahub-operator-main.yaml`
around lines 161 - 163, Regenerate the downstream CI artifacts affected by the
tls-scanner-run entry in the opendatahub-operator configuration using the
repository’s standard generation target, such as make update or the equivalent
jobs and metadata targets, then include all resulting generated diffs.

Sources: Coding guidelines, Learnings

workflow: generic-claim
- as: opendatahub-operator-image-mirror
postsubmit: true
Expand Down