Skip to content

STOR-3001: Add TLS scanner job to local-storage-operator #82673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 1 commit into from
Jul 30, 2026
Merged

STOR-3001: Add TLS scanner job to local-storage-operator #82673

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions ...erator/config/openshift/local-storage-operator/openshift-local-storage-operator-main.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ base_images:
name: tests-private
namespace: ci
tag: "4.22"
tls-scanner-tool:
name: tls-scanner
namespace: tls-scanner
tag: tls-scanner-tool
build_root:
from_repository: true
images:
Expand Down Expand Up @@ -94,6 +98,27 @@ tests:
test:
- ref: openshift-extended-test
workflow: optional-operators-ci-aws
- always_run: false
as: tls-scanner-local-storage
optional: true
steps:
cluster_profile: openshift-org-aws
dependencies:
OO_INDEX: ci-index-local-storage-operator-bundle
env:
OO_CHANNEL: preview
OO_INSTALL_NAMESPACE: openshift-local-storage
OO_PACKAGE: local-storage-operator
OO_TARGET_NAMESPACES: '!install'
SCAN_NAMESPACE: openshift-local-storage
SCANNER_CPU: "1"
SCANNER_MEMORY: 1Gi
TLS_13_ENABLE_TLS_ADHERENCE: "true"
TLS_13_TLS_ADHERENCE_POLICY: StrictAllComponents
test:
- ref: tls-13
- ref: tls-scanner-run
workflow: optional-operators-ci-aws
Comment on lines +101 to +121

@coderabbitai coderabbitai Bot Jul 30, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

Regenerate Prow jobs for all newly added scanner jobs. These named tests alter generated Prow-job configuration, but no generated artifacts are included.

  • ci-operator/config/openshift/local-storage-operator/openshift-local-storage-operator-main.yaml#L101-L121: run make update and commit generated output.
  • ci-operator/config/openshift/local-storage-operator/openshift-local-storage-operator-release-4.23.yaml#L101-L121: include the release-4.23 generated job.
  • ci-operator/config/openshift/local-storage-operator/openshift-local-storage-operator-release-5.0.yaml#L102-L122: include the release-5.0 generated job.
  • ci-operator/config/openshift/local-storage-operator/openshift-local-storage-operator-release-5.1.yaml#L101-L121: include the release-5.1 generated job.
📍 Affects 4 files
  • ci-operator/config/openshift/local-storage-operator/openshift-local-storage-operator-main.yaml#L101-L121 (this comment)
  • ci-operator/config/openshift/local-storage-operator/openshift-local-storage-operator-release-4.23.yaml#L101-L121
  • ci-operator/config/openshift/local-storage-operator/openshift-local-storage-operator-release-5.0.yaml#L102-L122
  • ci-operator/config/openshift/local-storage-operator/openshift-local-storage-operator-release-5.1.yaml#L101-L121
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@ci-operator/config/openshift/local-storage-operator/openshift-local-storage-operator-main.yaml`
around lines 101 - 121, Regenerate the Prow job artifacts for the
tls-scanner-local-storage test by running make update. Commit the generated
output for
ci-operator/config/openshift/local-storage-operator/openshift-local-storage-operator-main.yaml
lines 101-121, and add the corresponding generated jobs for
ci-operator/config/openshift/local-storage-operator/openshift-local-storage-operator-release-4.23.yaml
lines 101-121,
ci-operator/config/openshift/local-storage-operator/openshift-local-storage-operator-release-5.0.yaml
lines 102-122, and
ci-operator/config/openshift/local-storage-operator/openshift-local-storage-operator-release-5.1.yaml
lines 101-121.

Source: Coding guidelines

- as: verify-deps
steps:
test:
Expand Down
25 changes: 25 additions & 0 deletions ...onfig/openshift/local-storage-operator/openshift-local-storage-operator-release-4.23.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ base_images:
name: tests-private
namespace: ci
tag: "4.22"
tls-scanner-tool:
name: tls-scanner
namespace: tls-scanner
tag: tls-scanner-tool
build_root:
from_repository: true
images:
Expand Down Expand Up @@ -94,6 +98,27 @@ tests:
test:
- ref: openshift-extended-test
workflow: optional-operators-ci-aws
- always_run: false
as: tls-scanner-local-storage
optional: true
steps:
cluster_profile: openshift-org-aws
dependencies:
OO_INDEX: ci-index-local-storage-operator-bundle
env:
OO_CHANNEL: preview
OO_INSTALL_NAMESPACE: openshift-local-storage
OO_PACKAGE: local-storage-operator
OO_TARGET_NAMESPACES: '!install'
SCAN_NAMESPACE: openshift-local-storage
SCANNER_CPU: "1"
SCANNER_MEMORY: 1Gi
TLS_13_ENABLE_TLS_ADHERENCE: "true"
TLS_13_TLS_ADHERENCE_POLICY: StrictAllComponents
test:
- ref: tls-13
- ref: tls-scanner-run
workflow: optional-operators-ci-aws
- as: verify-deps
steps:
test:
Expand Down
25 changes: 25 additions & 0 deletions ...config/openshift/local-storage-operator/openshift-local-storage-operator-release-5.0.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ base_images:
name: tests-private
namespace: ci
tag: "4.22"
tls-scanner-tool:
name: tls-scanner
namespace: tls-scanner
tag: tls-scanner-tool
build_root:
from_repository: true
images:
Expand Down Expand Up @@ -95,6 +99,27 @@ tests:
test:
- ref: openshift-extended-test
workflow: optional-operators-ci-aws
- always_run: false
as: tls-scanner-local-storage
optional: true
steps:
cluster_profile: openshift-org-aws
dependencies:
OO_INDEX: ci-index-local-storage-operator-bundle
env:
OO_CHANNEL: preview
OO_INSTALL_NAMESPACE: openshift-local-storage
OO_PACKAGE: local-storage-operator
OO_TARGET_NAMESPACES: '!install'
SCAN_NAMESPACE: openshift-local-storage
SCANNER_CPU: "1"
SCANNER_MEMORY: 1Gi
TLS_13_ENABLE_TLS_ADHERENCE: "true"
TLS_13_TLS_ADHERENCE_POLICY: StrictAllComponents
test:
- ref: tls-13
- ref: tls-scanner-run
workflow: optional-operators-ci-aws
- as: verify-deps
steps:
test:
Expand Down
25 changes: 25 additions & 0 deletions ...config/openshift/local-storage-operator/openshift-local-storage-operator-release-5.1.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ base_images:
name: tests-private
namespace: ci
tag: "4.22"
tls-scanner-tool:
name: tls-scanner
namespace: tls-scanner
tag: tls-scanner-tool
build_root:
from_repository: true
images:
Expand Down Expand Up @@ -94,6 +98,27 @@ tests:
test:
- ref: openshift-extended-test
workflow: optional-operators-ci-aws
- always_run: false
as: tls-scanner-local-storage
optional: true
steps:
cluster_profile: openshift-org-aws
dependencies:
OO_INDEX: ci-index-local-storage-operator-bundle
env:
OO_CHANNEL: preview
OO_INSTALL_NAMESPACE: openshift-local-storage
OO_PACKAGE: local-storage-operator
OO_TARGET_NAMESPACES: '!install'
SCAN_NAMESPACE: openshift-local-storage
SCANNER_CPU: "1"
SCANNER_MEMORY: 1Gi
TLS_13_ENABLE_TLS_ADHERENCE: "true"
TLS_13_TLS_ADHERENCE_POLICY: StrictAllComponents
test:
- ref: tls-13
- ref: tls-scanner-run
workflow: optional-operators-ci-aws
- as: verify-deps
steps:
test:
Expand Down
87 changes: 87 additions & 0 deletions ...bs/openshift/local-storage-operator/openshift-local-storage-operator-main-presubmits.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,6 +377,93 @@ presubmits:
secret:
secretName: result-aggregator
trigger: (?m)^/test( | .* )security,?($|\s.*)
- agent: kubernetes
always_run: false
branches:
- ^main$
- ^main-
cluster: build09
context: ci/prow/tls-scanner-local-storage
decorate: true
decoration_config:
sparse_checkout_files:
- .ci-operator.yaml
- Dockerfile.diskmaker.rhel7
- Dockerfile.mustgather
- Dockerfile.rhel7
labels:
ci-operator.openshift.io/cloud: aws
ci-operator.openshift.io/cloud-cluster-profile: openshift-org-aws
ci.openshift.io/generator: prowgen
pj-rehearse.openshift.io/can-be-rehearsed: "true"
name: pull-ci-openshift-local-storage-operator-main-tls-scanner-local-storage
optional: true
rerun_command: /test tls-scanner-local-storage
spec:
containers:
- args:
- --gcs-upload-secret=/secrets/gcs/service-account.json
- --image-import-pull-secret=/etc/pull-secret/.dockerconfigjson
- --lease-server-credentials-file=/etc/boskos/credentials
- --report-credentials-file=/etc/report/credentials
- --secret-dir=/secrets/ci-pull-credentials
- --target=tls-scanner-local-storage
command:
- ci-operator
env:
- name: HTTP_SERVER_IP
valueFrom:
fieldRef:
fieldPath: status.podIP
image: quay-proxy.ci.openshift.org/openshift/ci:ci_ci-operator_latest
imagePullPolicy: Always
name: ""
ports:
- containerPort: 8080
name: http
resources:
requests:
cpu: 10m
volumeMounts:
- mountPath: /etc/boskos
name: boskos
readOnly: true
- mountPath: /secrets/ci-pull-credentials
name: ci-pull-credentials
readOnly: true
- mountPath: /secrets/gcs
name: gcs-credentials
readOnly: true
- mountPath: /secrets/manifest-tool
name: manifest-tool-local-pusher
readOnly: true
- mountPath: /etc/pull-secret
name: pull-secret
readOnly: true
- mountPath: /etc/report
name: result-aggregator
readOnly: true
serviceAccountName: ci-operator
volumes:
- name: boskos
secret:
items:
- key: credentials
path: credentials
secretName: boskos-credentials
- name: ci-pull-credentials
secret:
secretName: ci-pull-credentials
- name: manifest-tool-local-pusher
secret:
secretName: manifest-tool-local-pusher
- name: pull-secret
secret:
secretName: registry-pull-credentials
- name: result-aggregator
secret:
secretName: result-aggregator
trigger: (?m)^/test( | .* )tls-scanner-local-storage,?($|\s.*)
- agent: kubernetes
always_run: true
branches:
Expand Down
87 changes: 87 additions & 0 deletions ...hift/local-storage-operator/openshift-local-storage-operator-release-4.23-presubmits.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,6 +377,93 @@ presubmits:
secret:
secretName: result-aggregator
trigger: (?m)^/test( | .* )security,?($|\s.*)
- agent: kubernetes
always_run: false
branches:
- ^release-4\.23$
- ^release-4\.23-
cluster: build09
context: ci/prow/tls-scanner-local-storage
decorate: true
decoration_config:
sparse_checkout_files:
- .ci-operator.yaml
- Dockerfile.diskmaker.rhel7
- Dockerfile.mustgather
- Dockerfile.rhel7
labels:
ci-operator.openshift.io/cloud: aws
ci-operator.openshift.io/cloud-cluster-profile: openshift-org-aws
ci.openshift.io/generator: prowgen
pj-rehearse.openshift.io/can-be-rehearsed: "true"
name: pull-ci-openshift-local-storage-operator-release-4.23-tls-scanner-local-storage
optional: true
rerun_command: /test tls-scanner-local-storage
spec:
containers:
- args:
- --gcs-upload-secret=/secrets/gcs/service-account.json
- --image-import-pull-secret=/etc/pull-secret/.dockerconfigjson
- --lease-server-credentials-file=/etc/boskos/credentials
- --report-credentials-file=/etc/report/credentials
- --secret-dir=/secrets/ci-pull-credentials
- --target=tls-scanner-local-storage
command:
- ci-operator
env:
- name: HTTP_SERVER_IP
valueFrom:
fieldRef:
fieldPath: status.podIP
image: quay-proxy.ci.openshift.org/openshift/ci:ci_ci-operator_latest
imagePullPolicy: Always
name: ""
ports:
- containerPort: 8080
name: http
resources:
requests:
cpu: 10m
volumeMounts:
- mountPath: /etc/boskos
name: boskos
readOnly: true
- mountPath: /secrets/ci-pull-credentials
name: ci-pull-credentials
readOnly: true
- mountPath: /secrets/gcs
name: gcs-credentials
readOnly: true
- mountPath: /secrets/manifest-tool
name: manifest-tool-local-pusher
readOnly: true
- mountPath: /etc/pull-secret
name: pull-secret
readOnly: true
- mountPath: /etc/report
name: result-aggregator
readOnly: true
serviceAccountName: ci-operator
volumes:
- name: boskos
secret:
items:
- key: credentials
path: credentials
secretName: boskos-credentials
- name: ci-pull-credentials
secret:
secretName: ci-pull-credentials
- name: manifest-tool-local-pusher
secret:
secretName: manifest-tool-local-pusher
- name: pull-secret
secret:
secretName: registry-pull-credentials
- name: result-aggregator
secret:
secretName: result-aggregator
trigger: (?m)^/test( | .* )tls-scanner-local-storage,?($|\s.*)
- agent: kubernetes
always_run: true
branches:
Expand Down
Loading