NO-JIRA: add TLS scan jobs for HCO

[nunnatsa]

Summary by CodeRabbit

Adds optional AWS and Azure TLS scan jobs to the HCO OpenShift CI configuration. Both jobs install HCO, run tls-scanner-run, and run tls-13. The AWS job uses spot instances and enables KVM emulation.

[openshift-ci-robot]

@nunnatsa: This pull request explicitly references no jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nunnatsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• ci-operator/config/kubevirt/hyperconverged-cluster-operator/OWNERS [nunnatsa]
• ci-operator/jobs/kubevirt/hyperconverged-cluster-operator/OWNERS [nunnatsa]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: d886f81f-2f18-4c5e-a3c7-bef4bd0eba55

📥 Commits

Reviewing files that changed from the base of the PR and between 3b80bac and 4ef4107.

⛔ Files ignored due to path filters (1)

• ci-operator/jobs/kubevirt/hyperconverged-cluster-operator/kubevirt-hyperconverged-cluster-operator-main-presubmits.yaml is excluded by !ci-operator/jobs/**

📒 Files selected for processing (1)

• ci-operator/config/kubevirt/hyperconverged-cluster-operator/kubevirt-hyperconverged-cluster-operator-main.yaml

🚧 Files skipped from review as they are similar to previous changes (1)

• ci-operator/config/kubevirt/hyperconverged-cluster-operator/kubevirt-hyperconverged-cluster-operator-main.yaml

---

Walkthrough

Adds the tls-scanner-tool image and optional Azure and AWS CI jobs for HCO TLS scanning. The jobs configure scanner variables, deploy the custom resource, and run scanner tests. The AWS job also enables spot instances and KVM emulation.

Changes

HCO TLS scanning

Layer / File(s)	Summary
Configure TLS scanner image and cloud jobs ci-operator/config/kubevirt/hyperconverged-cluster-operator/kubevirt-hyperconverged-cluster-operator-main.yaml	Adds the tls-scanner-tool base image and optional Azure and AWS scan jobs. The jobs configure TLS scanner variables, deploy the custom resource, and run scanner commands. The AWS job enables spot instances and KVM emulation.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

• openshift/release#82715: Adds similar optional TLS scanner CI jobs for another operator.

Suggested reviewers: avlitman

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: adding TLS scan jobs for HCO.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The commit changes only YAML CI configuration; added job and step names are static, and no Ginkgo title syntax or dynamic identifiers appear in the diff.
Test Structure And Quality	✅ Passed	The PR changes only ci-operator YAML configuration and generated presubmit YAML; it adds no Ginkgo It blocks or test code for this check to review.
Microshift Test Compatibility	✅ Passed	The pull request changes only CI YAML and generated Prow job definitions. It adds no Ginkgo e2e tests or MicroShift-incompatible test code.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The PR changes only two YAML CI configuration files and adds TLS scan job steps; it adds no Ginkgo tests or multi-node assumptions requiring SNO review.
Topology-Aware Scheduling Compatibility	✅ Passed	The PR changes only CI configuration and generated Prow jobs; it adds no deployment, operator, controller, affinity, topology spread, node selector, replica, taint, or PDB constraints.
Ote Binary Stdout Contract	✅ Passed	The PR changes only two YAML files and adds no OTE source or process-level stdout writes; TLS references point to existing shell/YAML steps.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The diff adds only CI YAML and generated Prow job configuration; it adds no Ginkgo tests or test source requiring IPv4 or public connectivity.
No-Weak-Crypto	✅ Passed	The commit changes only YAML job configuration and generated presubmits; added lines contain no MD5, SHA1, DES, RC4, Blowfish, ECB, custom crypto, or secret comparisons.
Container-Privileges	✅ Passed	The added Azure and AWS job manifests contain no privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, root, or allowPrivilegeEscalation settings.
No-Sensitive-Data-In-Logs	✅ Passed	The added YAML contains only job settings and commands; it adds no logging, secret values, tokens, passwords, PII, or API keys.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[nunnatsa]

/pj-rehearse pull-ci-kubevirt-hyperconverged-cluster-operator-main-hco-tls-scan-aws pull-ci-kubevirt-hyperconverged-cluster-operator-main-hco-tls-scan-azure

[openshift-merge-bot]

@nunnatsa: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[nunnatsa]

/pj-rehearse pull-ci-kubevirt-hyperconverged-cluster-operator-main-hco-tls-scan-azure

[openshift-merge-bot]

@nunnatsa: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[nunnatsa]

/pj-rehearse pull-ci-kubevirt-hyperconverged-cluster-operator-main-hco-tls-scan-aws pull-ci-kubevirt-hyperconverged-cluster-operator-main-hco-tls-scan-azure

[openshift-merge-bot]

@nunnatsa: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[coderabbitai]

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

[nunnatsa]

/pj-rehearse pull-ci-kubevirt-hyperconverged-cluster-operator-main-hco-tls-scan-aws pull-ci-kubevirt-hyperconverged-cluster-operator-main-hco-tls-scan-azure

[openshift-merge-bot]

@nunnatsa: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[nunnatsa]

/pj-rehearse ack

[openshift-merge-bot]

@nunnatsa: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[orenc1]

why there is no - ref: tls-13 step on the aws job?

[nunnatsa]

fixed

[coderabbitai]

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

[nunnatsa]

/pj-rehearse pull-ci-kubevirt-hyperconverged-cluster-operator-main-hco-tls-scan-aws pull-ci-kubevirt-hyperconverged-cluster-operator-main-hco-tls-scan-azure

[openshift-merge-bot]

@nunnatsa: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@nunnatsa: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-kubevirt-hyperconverged-cluster-operator-main-hco-tls-scan-aws	kubevirt/hyperconverged-cluster-operator	presubmit	Presubmit changed
pull-ci-kubevirt-hyperconverged-cluster-operator-main-hco-tls-scan-azure	kubevirt/hyperconverged-cluster-operator	presubmit	Presubmit changed
pull-ci-kubevirt-hyperconverged-cluster-operator-main-ci-index-hco-bundle	kubevirt/hyperconverged-cluster-operator	presubmit	Ci-operator config changed
pull-ci-kubevirt-hyperconverged-cluster-operator-main-ci-index-hco-upgrade-operator-sdk-bundle	kubevirt/hyperconverged-cluster-operator	presubmit	Ci-operator config changed
pull-ci-kubevirt-hyperconverged-cluster-operator-main-hco-e2e-consecutive-operator-sdk-upgrades-aws	kubevirt/hyperconverged-cluster-operator	presubmit	Ci-operator config changed
pull-ci-kubevirt-hyperconverged-cluster-operator-main-hco-e2e-consecutive-operator-sdk-upgrades-azure	kubevirt/hyperconverged-cluster-operator	presubmit	Ci-operator config changed
pull-ci-kubevirt-hyperconverged-cluster-operator-main-hco-e2e-kv-smoke-azure	kubevirt/hyperconverged-cluster-operator	presubmit	Ci-operator config changed
pull-ci-kubevirt-hyperconverged-cluster-operator-main-hco-e2e-kv-smoke-gcp	kubevirt/hyperconverged-cluster-operator	presubmit	Ci-operator config changed
pull-ci-kubevirt-hyperconverged-cluster-operator-main-hco-e2e-operator-sdk-aws	kubevirt/hyperconverged-cluster-operator	presubmit	Ci-operator config changed
pull-ci-kubevirt-hyperconverged-cluster-operator-main-hco-e2e-operator-sdk-azure	kubevirt/hyperconverged-cluster-operator	presubmit	Ci-operator config changed
pull-ci-kubevirt-hyperconverged-cluster-operator-main-hco-e2e-operator-sdk-gcp	kubevirt/hyperconverged-cluster-operator	presubmit	Ci-operator config changed
pull-ci-kubevirt-hyperconverged-cluster-operator-main-hco-e2e-operator-sdk-sno-aws	kubevirt/hyperconverged-cluster-operator	presubmit	Ci-operator config changed
pull-ci-kubevirt-hyperconverged-cluster-operator-main-hco-e2e-operator-sdk-sno-azure	kubevirt/hyperconverged-cluster-operator	presubmit	Ci-operator config changed
pull-ci-kubevirt-hyperconverged-cluster-operator-main-hco-e2e-upgrade-operator-sdk-aws	kubevirt/hyperconverged-cluster-operator	presubmit	Ci-operator config changed
pull-ci-kubevirt-hyperconverged-cluster-operator-main-hco-e2e-upgrade-operator-sdk-azure	kubevirt/hyperconverged-cluster-operator	presubmit	Ci-operator config changed
pull-ci-kubevirt-hyperconverged-cluster-operator-main-hco-e2e-upgrade-operator-sdk-sno-aws	kubevirt/hyperconverged-cluster-operator	presubmit	Ci-operator config changed
pull-ci-kubevirt-hyperconverged-cluster-operator-main-hco-e2e-upgrade-operator-sdk-sno-azure	kubevirt/hyperconverged-cluster-operator	presubmit	Ci-operator config changed
pull-ci-kubevirt-hyperconverged-cluster-operator-main-hco-e2e-upgrade-prev-operator-sdk-aws	kubevirt/hyperconverged-cluster-operator	presubmit	Ci-operator config changed
pull-ci-kubevirt-hyperconverged-cluster-operator-main-hco-e2e-upgrade-prev-operator-sdk-azure	kubevirt/hyperconverged-cluster-operator	presubmit	Ci-operator config changed
pull-ci-kubevirt-hyperconverged-cluster-operator-main-hco-e2e-upgrade-prev-operator-sdk-sno-aws	kubevirt/hyperconverged-cluster-operator	presubmit	Ci-operator config changed
pull-ci-kubevirt-hyperconverged-cluster-operator-main-hco-e2e-upgrade-prev-operator-sdk-sno-azure	kubevirt/hyperconverged-cluster-operator	presubmit	Ci-operator config changed
pull-ci-kubevirt-hyperconverged-cluster-operator-main-images	kubevirt/hyperconverged-cluster-operator	presubmit	Ci-operator config changed
periodic-ci-kubevirt-hyperconverged-cluster-operator-main-hco-e2e-deploy-nightly-main-aws	N/A	periodic	Ci-operator config changed

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[openshift-ci]

@nunnatsa: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/rehearse/kubevirt/hyperconverged-cluster-operator/main/hco-tls-scan-aws	4ef4107	link	unknown	/pj-rehearse pull-ci-kubevirt-hyperconverged-cluster-operator-main-hco-tls-scan-aws
ci/rehearse/kubevirt/hyperconverged-cluster-operator/main/hco-tls-scan-azure	4ef4107	link	unknown	/pj-rehearse pull-ci-kubevirt-hyperconverged-cluster-operator-main-hco-tls-scan-azure

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.