Skip to content

chore(rhdh-operator): update branch protection rules#81092

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
rm3l:patch-1
Jun 26, 2026
Merged

chore(rhdh-operator): update branch protection rules#81092
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
rm3l:patch-1

Conversation

@rm3l

@rm3l rm3l commented Jun 25, 2026

Copy link
Copy Markdown
Member

Removed branch configurations for unmaintained 1.2.x, release-1.3, and release-1.4. Updated required status checks for the main branch to reflect recent changes in the job names.

Otherwise, all PRs (example) against main are blocked due to this branch protection rule automatically sync'ed and enforced in the rhdh-operator repo settings. "PR Publish" will never be triggered:

image

Summary by CodeRabbit

Updated the rhdh-operator CI branch protection configuration to reflect the current supported branches and job names. This removes protection rules for the unmaintained 1.2.x, release-1.3, and release-1.4 branches, and adjusts the main branch required checks so merges now depend on the latest validation jobs (PR Validate, Validate Dockerfile, and Validate Bundle Manifests) instead of the older PR Publish check.

Removed branch configurations for unmaintained 1.2.x, release-1.3, and release-1.4. Updated required status checks for the main branch to reflect recent changes in the job names.
@coderabbitai

coderabbitai Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Walkthrough

The branch protection config for redhat-developer/rhdh-operator now defines required status checks on main. It removes the prior 1.2.x required-check block and replaces PR Publish with Validate Dockerfile and Validate Bundle Manifests alongside PR Validate.

Changes

Branch protection check updates

Layer / File(s) Summary
Main branch protection checks
core-services/prow/02_config/redhat-developer/rhdh-operator/_prowconfig.yaml
main branch protection now adds enforce_admins/protect and requires PR Validate, Validate Dockerfile, and Validate Bundle Manifests; the prior 1.2.x required-status-checks block and PR Publish context are removed.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

Possibly related PRs

  • openshift/release#80705: Also updates _prowconfig.yaml branch-protection required status checks for a repository branch.
  • openshift/release#80765: Also changes Prow branch-protection required contexts on a main branch configuration.

Suggested labels

lgtm, approved

Suggested reviewers

  • smarthall
  • samanthajayasinghe
🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the main change: updating rhdh-operator branch protection rules.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR only changes _prowconfig.yaml branch protection; no Ginkgo test titles or test files were modified.
Test Structure And Quality ✅ Passed Only a Prow branch-protection YAML changed; no Ginkgo test files or test logic were modified, so this check is not applicable.
Microshift Test Compatibility ✅ Passed PR only edits branch-protection YAML; no Ginkgo e2e tests were added or modified, so MicroShift compatibility is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed Only rhdh-operator prow config YAML changed; no Go/e2e test files or Ginkgo specs were added or modified, so SNO compatibility is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed Only a prow branch-protection YAML changed; no manifests, operator code, or controllers were modified, so no topology-aware scheduling risk.
Ote Binary Stdout Contract ✅ Passed PR only changes Prow branch-protection YAML; no Go/test binaries or process-level stdout writes were touched, so the stdout contract check is not applicable.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR only changes Prow branch-protection YAML; no Ginkgo e2e tests or network code were added, so the IPv6/disconnected-network check is not applicable.
No-Weak-Crypto ✅ Passed The only touched file is a Prow YAML config, and it contains no weak-crypto algorithms or secret comparisons.
Container-Privileges ✅ Passed PR only updates Prow branch-protection YAML; no container/K8s manifests or privilege fields are present in the changed content.
No-Sensitive-Data-In-Logs ✅ Passed The PR only updates Prow branch-protection YAML; no log statements or sensitive-data patterns appear in the touched file.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 25, 2026
@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jun 25, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@rm3l: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@core-services/prow/02_config/redhat-developer/rhdh-operator/_prowconfig.yaml`:
- Around line 15-16: The required status checks in the Prow config include
contexts that are not produced anywhere in this repo, so update the
_prowconfig.yaml entry for required_status_checks.contexts to remove “Validate
Dockerfile” and “Validate Bundle Manifests” unless you also add matching jobs
under ci-operator/config/redhat-developer/rhdh-operator/. If these are meant to
be conditional validations, move them to required-if-present-contexts instead so
they do not block merges when no job exists.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 38723b32-4e9c-4c7b-b807-628acada1cdf

📥 Commits

Reviewing files that changed from the base of the PR and between 9fbefed and e3550a5.

📒 Files selected for processing (1)
  • core-services/prow/02_config/redhat-developer/rhdh-operator/_prowconfig.yaml

@openshift-ci

openshift-ci Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

@rm3l: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@subhashkhileri

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 26, 2026
@openshift-ci

openshift-ci Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rm3l, subhashkhileri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot merged commit 898a6c7 into openshift:main Jun 26, 2026
12 checks passed
@openshift-ci

openshift-ci Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

@rm3l: Updated the following 2 configmaps:

  • config configmap in namespace ci at cluster app.ci using the following files:
    • key core-services-prow-02_config-redhat-developer-rhdh-operator-_prowconfig.yaml using file core-services/prow/02_config/redhat-developer/rhdh-operator/_prowconfig.yaml
  • config configmap in namespace ci at cluster core-ci using the following files:
    • key core-services-prow-02_config-redhat-developer-rhdh-operator-_prowconfig.yaml using file core-services/prow/02_config/redhat-developer/rhdh-operator/_prowconfig.yaml
Details

In response to this:

Removed branch configurations for unmaintained 1.2.x, release-1.3, and release-1.4. Updated required status checks for the main branch to reflect recent changes in the job names.

Otherwise, all PRs (example) against main are blocked due to this branch protection rule automatically sync'ed and enforced in the rhdh-operator repo settings. "PR Publish" will never be triggered:

image

Summary by CodeRabbit

Updated the rhdh-operator CI branch protection configuration to reflect the current supported branches and job names. This removes protection rules for the unmaintained 1.2.x, release-1.3, and release-1.4 branches, and adjusts the main branch required checks so merges now depend on the latest validation jobs (PR Validate, Validate Dockerfile, and Validate Bundle Manifests) instead of the older PR Publish check.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tbuskey pushed a commit to tbuskey/release that referenced this pull request Jun 26, 2026
Removed branch configurations for unmaintained 1.2.x, release-1.3, and release-1.4. Updated required status checks for the main branch to reflect recent changes in the job names.
kasturinarra pushed a commit to kasturinarra/release that referenced this pull request Jun 26, 2026
Removed branch configurations for unmaintained 1.2.x, release-1.3, and release-1.4. Updated required status checks for the main branch to reflect recent changes in the job names.
krisnababu pushed a commit to oharan2/release that referenced this pull request Jul 3, 2026
Removed branch configurations for unmaintained 1.2.x, release-1.3, and release-1.4. Updated required status checks for the main branch to reflect recent changes in the job names.
andrej1991 pushed a commit to andrej1991/release that referenced this pull request Jul 6, 2026
Removed branch configurations for unmaintained 1.2.x, release-1.3, and release-1.4. Updated required status checks for the main branch to reflect recent changes in the job names.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants