WIP: Add slack_channel to Service Mesh LP interop firewatch config by danalanerh · Pull Request #80687 · openshift/release

danalanerh · 2026-06-17T18:07:36Z

Summary

Add slack_channel field to FIREWATCH_CONFIG failure rules for Service Mesh sail-operator LP interop tests to enable notifications to the #team-ossm-qe channel.

This implements the new firewatch feature from RedHatQE/firewatch#277

Changes

Added "slack_channel": "#team-ossm-qe" to all failure rules in both tests:
- cr-servicemesh-aws
- servicemesh-aws-fips

Test plan

CI validation passes
make update generates job files correctly
Firewatch notifications are sent to #team-ossm-qe on test failures

Note: This PR is marked WIP because make update needs to be run to regenerate the job files (make was not available in the environment where this was created).

🤖 Generated with Claude Code

Summary by CodeRabbit

This PR enhances the Slack notification integration for the Service Mesh sail-operator LP interop test CI jobs by adding slack_channel configuration to firewatch failure rules.

What changed:
The CI configuration for the sail-operator's OpenShift integration tests (cr-servicemesh-aws and servicemesh-aws-fips) now includes "slack_channel": "#team-ossm-qe" in all failure rule entries within the embedded FIREWATCH_CONFIG. This applies to all nine failure detection rules covering:

Sail operator E2E test execution and failures
Istio installation provisioning
Kiali integration test execution and failures
Kiali Cypress test execution and failures
Kiali OSSMC Cypress test execution and failures

Practical impact:
Test failures detected by firewatch in these CI jobs will now automatically send notifications to the #team-ossm-qe Slack channel in addition to creating JIRA tickets. This leverages a new firewatch feature introduced in RedHatQE/firewatch#277.

Note:
This PR is marked as work in progress. The corresponding Prow job definition files need to be regenerated by running make update, which will sync the changes from the CI configuration source to the generated job manifests in ci-operator/jobs/. This step is pending completion.

Add slack_channel field to FIREWATCH_CONFIG failure rules for Service Mesh sail-operator LP interop tests to enable notifications to #team-ossm-qe channel. Related: INTEROP-9017 Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

openshift-ci · 2026-06-17T18:08:03Z

Hi @danalanerh. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

coderabbitai · 2026-06-17T18:08:03Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 88d06062-68cb-43d5-9399-0ece6eb613cf

📥 Commits

Reviewing files that changed from the base of the PR and between 5889413 and 76e8eba.

📒 Files selected for processing (1)

ci-operator/config/openshift-service-mesh/sail-operator/openshift-service-mesh-sail-operator-lpinterop-3.3__ocp-4.22-lp-interop.yaml

Walkthrough

Two AWS test jobs (cr-servicemesh-aws and servicemesh-aws-fips) in the sail-operator lp-interop CI config have their FIREWATCH_CONFIG failure_rules updated to include slack_channel: "#team-ossm-qe" for all Sail operator E2E, Istio install, and Kiali failure-rule entries.

Changes

Firewatch Slack Channel Configuration

Layer / File(s)	Summary
Add `slack_channel` to both jobs' failure_rules `ci-operator/config/openshift-service-mesh/sail-operator/openshift-service-mesh-sail-operator-lpinterop-3.3__ocp-4.22-lp-interop.yaml`	Adds `slack_channel: "`#team-ossm-qe`"` to each `failure_rules` entry (Sail E2E, Istio install, Kiali integration, Kiali Cypress/OSSMC) in both `cr-servicemesh-aws` and `servicemesh-aws-fips` jobs. No other fields are modified.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the main change: adding slack_channel configuration to Service Mesh firewatch config. It is specific, concise, and accurately reflects the primary modification in the changeset.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PR modifies only CI YAML configuration (FIREWATCH_CONFIG), not Ginkgo test code. Custom check for stable test names only applies to test code, not configuration files.
Test Structure And Quality	✅ Passed	This PR modifies only CI operator YAML configuration to add slack_channel fields to firewatch rules. The custom check for Ginkgo test code quality is not applicable to YAML configuration files.
Microshift Test Compatibility	✅ Passed	This PR only modifies CI configuration (YAML firewatch settings) and does not add any new Ginkgo e2e tests, making the MicroShift test compatibility check not applicable.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PR adds no new Ginkgo e2e tests. Changes are limited to CI configuration (YAML) that adds slack_channel fields to firewatch failure rules. SNO compatibility check does not apply.
Topology-Aware Scheduling Compatibility	✅ Passed	This PR modifies only a CI configuration file to add slack_channel fields to firewatch test notifications; it does not introduce any deployment manifests, operator code, or scheduling constraints a...
Ote Binary Stdout Contract	✅ Passed	PR only modifies YAML CI configuration files; custom check is for Go code stdout violations, making it not applicable.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	This PR only modifies CI configuration (FIREWATCH_CONFIG in YAML), not Ginkgo e2e test code. No new tests are added, so the IPv6/disconnected network check is not applicable.
No-Weak-Crypto	✅ Passed	PR only modifies YAML CI/CD configuration to add Slack channel fields to firewatch failure rules; no cryptographic code, weak algorithms, custom crypto implementations, or secret comparisons are in...
Container-Privileges	✅ Passed	The PR modifies only a CI-operator configuration file (not a K8s manifest). No container privilege-related fields (privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, allowPrivilegeEscalation) ar...
No-Sensitive-Data-In-Logs	✅ Passed	PR only adds slack_channel field set to public channel name `#team-ossm-qe` in firewatch config; no passwords, tokens, API keys, PII, or sensitive data are exposed.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

openshift-ci · 2026-06-17T18:08:29Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: danalanerh
Once this PR has been reviewed and has the lgtm label, please assign jwendell for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

ci-operator/config/openshift-service-mesh/sail-operator/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-merge-bot · 2026-06-17T18:14:10Z

[REHEARSALNOTIFIER]
@danalanerh: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
periodic-ci-openshift-service-mesh-sail-operator-lpinterop-3.3-ocp-4.22-lp-interop-cr-servicemesh-aws	N/A	periodic	Ci-operator config changed
periodic-ci-openshift-service-mesh-sail-operator-lpinterop-3.3-ocp-4.22-lp-interop-servicemesh-aws-fips	N/A	periodic	Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

danalanerh · 2026-06-17T19:11:27Z

/pj-rehearse

openshift-merge-bot · 2026-06-17T19:12:47Z

@danalanerh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

openshift-merge-bot · 2026-06-17T19:12:48Z

@danalanerh: needs-ok-to-test label found, no rehearsals will be run

mkralik3 · 2026-06-18T08:24:12Z

 - as: servicemesh-aws-fips
  cron: 0 23 31 2 *
  reporter_config:
    channel: '#ossm-qe-ci'


@danalanerh
We already have slack reporter set here. e.g. how it looks like:

Should this line be deleted in favor of firewatch reporter? (or is there different behavior? e.g. only failures are reported? )

No, I left this as a WIP on purpose, I wanted to check how AI tooling handled the documentation around this new feature. I will close this PR.

danalanerh · 2026-06-18T17:46:30Z

This was created in testing some AI handling, closing PR

openshift-ci Bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 17, 2026

openshift-ci Bot requested review from dcillera and mkralik3 June 17, 2026 18:08

mkralik3 reviewed Jun 18, 2026

View reviewed changes

danalanerh closed this Jun 18, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

WIP: Add slack_channel to Service Mesh LP interop firewatch config - #80687

WIP: Add slack_channel to Service Mesh LP interop firewatch config#80687
danalanerh wants to merge 1 commit into
openshift:mainfrom
danalanerh:add-slack-channel-ossm-lpinterop

danalanerh commented Jun 17, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

openshift-ci Bot commented Jun 17, 2026

Uh oh!

coderabbitai Bot commented Jun 17, 2026 •

edited

Loading

Uh oh!

openshift-ci Bot commented Jun 17, 2026

Uh oh!

openshift-merge-bot Bot commented Jun 17, 2026

Uh oh!

danalanerh commented Jun 17, 2026

Uh oh!

openshift-merge-bot Bot commented Jun 17, 2026

Uh oh!

openshift-merge-bot Bot commented Jun 17, 2026

Uh oh!

mkralik3 Jun 18, 2026 •

edited

Loading

Uh oh!

danalanerh Jun 18, 2026

Uh oh!

danalanerh commented Jun 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

danalanerh commented Jun 17, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Related

Test plan

Summary by CodeRabbit

Uh oh!

openshift-ci Bot commented Jun 17, 2026

Uh oh!

coderabbitai Bot commented Jun 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Uh oh!

openshift-ci Bot commented Jun 17, 2026

Uh oh!

openshift-merge-bot Bot commented Jun 17, 2026

Uh oh!

danalanerh commented Jun 17, 2026

Uh oh!

openshift-merge-bot Bot commented Jun 17, 2026

Uh oh!

openshift-merge-bot Bot commented Jun 17, 2026

Uh oh!

mkralik3 Jun 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

danalanerh Jun 18, 2026

Choose a reason for hiding this comment

Uh oh!

danalanerh commented Jun 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

danalanerh commented Jun 17, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jun 17, 2026 •

edited

Loading

mkralik3 Jun 18, 2026 •

edited

Loading