OPRUN-4569: test: remove OTE exceptions for OLM

[tmshort]

Remove three exception callbacks that were suppressing test failures for now-fixed ClusterOperator condition false alarms in OLM components:

• OCPBUGS-62517: olm Available=False during rolling update — fixed by cluster-olm-operator PR Removed all Google copyrights' leftovers #202 (2 replicas + PDB on HA topology)
• OCPBUGS-62635: olm Progressing=True during MCO upgrade window — fixed by same PR Removed all Google copyrights' leftovers #202 (PDB prevents zero-pod rollout)
• OCPBUGS-63672: operator-lifecycle-manager-packageserver Progressing=True on empty reason during pod disruption — fixed by operator-framework-olm commit 3071726a6 (isAPIServiceBackendDisrupted returns RetryableError)

The operator-lifecycle-manager exception (OCPBUGS-65583) is intentionally kept; OLMv0 is in maintenance mode and the team decided not to change it.

Summary by CodeRabbit

Release Notes

• Tests

  • Refined cluster upgrade operator state transition validation tests by removing legacy exception cases for operator lifecycle manager and packageserver components, enabling stricter operator deployment state monitoring during upgrades

• Chores

  • Removed obsolete test accommodations and cleaned up outdated exception handling from operator monitoring checks to improve test coverage and reliability

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 87bf07a1-6d49-4448-a1ef-670e972eb34a

📥 Commits

Reviewing files that changed from the base of the PR and between 65f4e3a and d4990fe.

📒 Files selected for processing (1)

• pkg/monitortests/clusterversionoperator/legacycvomonitortests/operators.go

💤 Files with no reviewable changes (1)

• pkg/monitortests/clusterversionoperator/legacycvomonitortests/operators.go

---

Walkthrough

This PR removes exception-handling logic from cluster version operator upgrade tests for three operators (olm and packageserver), reflecting fixes for previously documented bugs. The changes clean up test workarounds by deleting 19 lines of conditional exception mappings.

Changes

Operator Exception Cleanup

Layer / File(s)	Summary
Test Exception Logic pkg/monitortests/clusterversionoperator/legacycvomonitortests/operators.go	Removes except mappings in testUpgradeOperatorStateTransitions and testUpgradeOperatorProgressingStateTransitions for olm (when reason ends with ControllerManager_Deploying) and operator-lifecycle-manager-packageserver (when reason is empty), as these bugs are now resolved.

---

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 12

✅ Passed checks (12 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The PR title directly matches the main change: removing OTE (Operator Test Exception) exceptions for OLM, as confirmed by the detailed objectives and file-level summary.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	Test names are stable and deterministic. No dynamic values like timestamps, UUIDs, pod/node names, or IPs are present in any test names.
Test Structure And Quality	✅ Passed	Not applicable. Code uses monitor test helpers, not Ginkgo tests. Custom check requires Ginkgo patterns (It blocks, BeforeEach/AfterEach) not present here.
Microshift Test Compatibility	✅ Passed	This PR removes test exception logic from helper functions in operators.go, not adding new Ginkgo e2e tests. The custom check only applies to new tests, so it does not apply here.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	No new Ginkgo e2e tests are added. The operators.go file contains 0 It(), Describe(), Context() definitions. It defines helper functions generating JUnit test cases for monitor tests, not e2e tests.
Topology-Aware Scheduling Compatibility	✅ Passed	PR modifies only test code, removing exceptions for bugs fixed in upstream OLM operators. No deployment manifests, Pod specs, affinity rules, or scheduling constraints are introduced or modified.
Ote Binary Stdout Contract	✅ Passed	PR modifies a monitor test library (pkg/monitortests/), not an OTE binary. No process-level stdout writes to check—only test callback functions which are excluded from scope.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	No new Ginkgo e2e tests (It, Describe, etc.) are added. The PR only modifies exception callbacks in test utility code, not test definitions.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}