test/extended/networking: OCPBUGS-82501 - Fix DualStack EgressFirewal…#31147
test/extended/networking: OCPBUGS-82501 - Fix DualStack EgressFirewal…#31147shreyasbe wants to merge 2 commits intoopenshift:mainfrom
Conversation
…l CI fail on AWS Signed-off-by: Shreyas B <shbehera@redhat.com> Signed-off-by: Shreyas Be <52690686+shreyasbe@users.noreply.github.com>
|
Pipeline controller notification For optional jobs, comment This repository is configured in: automatic mode |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThe test function sendEgressFwTraffic was changed to replace quiet single-step curl checks for https://redhat.com and https://www.redhat.com with multi-step diagnostics: run nslookup, run verbose curl with a connect timeout, run a second curl that prints the resolved remote IP and HTTP code, and update assertions to use the new diagnostic results. ChangesEgress Firewall Test Diagnostics
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes 🚥 Pre-merge checks | ✅ 8 | ❌ 4❌ Failed checks (4 warnings)
✅ Passed checks (8 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: shreyasbe The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (2)
test/extended/networking/egress_firewall.go (2)
225-229: ⚡ Quick winDuplicate
g.Bystep name makes CI output ambiguousLine 227 uses the same
g.By("sending traffic that does not match allow dns rule")already present at line 204 forwww.redhat.com. Two test steps with the same name in a singleItblock are hard to distinguish in CI logs, which undermines the diagnostic intent of this change.🔧 Proposed fix
- g.By("sending traffic that does not match allow dns rule") - _, err = oc.Run("exec").Args(pod, "--", "curl", "-q", "-s", "-I", "-m5", "https://www.apple.com").Output() + g.By("sending traffic to www.apple.com that does not match allow dns rule") + _, err = oc.Run("exec").Args(pod, "--", "curl", "-q", "-s", "-I", "-m5", "https://www.apple.com").Output()🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@test/extended/networking/egress_firewall.go` around lines 225 - 229, Duplicate test step description: replace the repeated g.By("sending traffic that does not match allow dns rule") used for the www.apple.com curl with a distinct message so CI output is unambiguous (e.g., mention www.apple.com or "apple.com" specifically); locate the g.By call paired with the curl command that runs oc.Run("exec").Args(pod, "--", "curl", ... "https://www.apple.com") and update the string passed to g.By to uniquely identify this step.
225-229: ⚡ Quick winDisambiguate the
g.Bylabel for thewww.apple.comstepLine 227 reuses the identical
g.By("sending traffic that does not match allow dns rule")string already present at line 204 forwww.redhat.com. Two indistinguishable step names in the sameItblock make CI log triage harder — the very scenario this PR is trying to improve.🔧 Proposed fix
- g.By("sending traffic that does not match allow dns rule") - _, err = oc.Run("exec").Args(pod, "--", "curl", "-q", "-s", "-I", "-m5", "https://www.apple.com").Output() + g.By("sending traffic to www.apple.com that does not match allow dns rule") + _, err = oc.Run("exec").Args(pod, "--", "curl", "-q", "-s", "-I", "-m5", "https://www.apple.com").Output()🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@test/extended/networking/egress_firewall.go` around lines 225 - 229, The test step re-uses the same g.By message as the earlier www.redhat.com check, making logs ambiguous; update the g.By call in the www.apple.com curl block (the line invoking g.By before oc.Run("exec") for curl https://www.apple.com) to use a distinct label that includes the hostname (e.g., mention "www.apple.com") so the step is uniquely identifiable in CI logs.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@test/extended/networking/egress_firewall.go`:
- Around line 225-229: Duplicate test step description: replace the repeated
g.By("sending traffic that does not match allow dns rule") used for the
www.apple.com curl with a distinct message so CI output is unambiguous (e.g.,
mention www.apple.com or "apple.com" specifically); locate the g.By call paired
with the curl command that runs oc.Run("exec").Args(pod, "--", "curl", ...
"https://www.apple.com") and update the string passed to g.By to uniquely
identify this step.
- Around line 225-229: The test step re-uses the same g.By message as the
earlier www.redhat.com check, making logs ambiguous; update the g.By call in the
www.apple.com curl block (the line invoking g.By before oc.Run("exec") for curl
https://www.apple.com) to use a distinct label that includes the hostname (e.g.,
mention "www.apple.com") so the step is uniquely identifiable in CI logs.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: a33b059e-311a-49e4-aee8-37232d8756dc
📒 Files selected for processing (1)
test/extended/networking/egress_firewall.go
openshift-merge-bot
Bot
added
the
ready-for-human-review
|
/test ? |
|
/test e2e-aws-ovn |
|
@shreyasbe: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/test e2e-aws-ovn-installer-dualstack-ipv4-primary-techpreview |
|
Scheduling required tests: |
1 participant
…l CI fail on AWS
Summary by CodeRabbit