CNTRLPLANE-3387: Update list of pending namespaces in the required-scc monitor test#31135
CNTRLPLANE-3387: Update list of pending namespaces in the required-scc monitor test#31135liouk wants to merge 1 commit intoopenshift:mainfrom
Conversation
In particular, remove namespaces which have now complete scc pinning in their workloads.
|
Pipeline controller notification For optional jobs, comment This repository is configured in: automatic mode |
|
@liouk: This pull request references CNTRLPLANE-876 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
WalkthroughThe pull request narrows the set of namespaces tracked for pending SCC pinning in a monitor test from multiple entries to four specific ones: ChangesSCC Pinning Monitor Configuration
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 12✅ Passed checks (12 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Scheduling required tests: |
|
@liouk: This pull request references CNTRLPLANE-3387 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@liouk: This pull request references CNTRLPLANE-3387 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest-required |
|
/lgtm Nit: How do we know these namespaces are fixed completely? |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ehearne-redhat, everettraven, liouk The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
/verified by @liouk |
|
@liouk: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@ehearne-redhat take a look at my previous comment; recent sippy runs show no failures, plus I've located the PRs that fixed the outstanding workloads. Removing these namespaces from the pending list means that in case any new/unfixed workload is detected, we'll get a failure and this should surface in component readiness for the appropriate component. |
|
@liouk: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Removing fixed namespaces from the pending list. This effectively means that the test will now be enforced on those as well by failing when a workload w/o SCC pinning is detected by the test.
Summary by CodeRabbit