OCPBUGS-85087: Allow OVN-Kubernetes CIDROverlap pathological events

[jcaamano]

OVN-Kubernetes EVPN e2e tests when running in parallel create multiple VTEP resources with the same CIDR. OVN-Kubernetes logs this through events with no further consequence other than reporting the wasteful resource use. When sufficient EVPN e2e tests run in parallel, monitoring pathological event tracker picks this up and fails the job.

https://redhat.atlassian.net/browse/OCPBUGS-85087 will fix the tests to share the same VTEP resource. Until then, add an exception for the event.

Summary by CodeRabbit

• New Features
  • Enhanced network monitoring capabilities to detect overlaps between OVN Kubernetes cluster network configurations and VTEP virtual tunnel endpoint network configurations. This improvement provides better visibility into potential network configuration conflicts, enabling proactive identification and resolution of compatibility issues that could affect cluster stability.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

[openshift-ci-robot]

@jcaamano: This pull request references Jira Issue OCPBUGS-85087, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.0.0) matches configured target version for branch (5.0.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

OVN-Kubernetes EVPN e2e tests when running in parallel create multiple VTEP resources with the same CIDR. OVN-Kubernetes logs this through events with no further consequence other than reporting the wasteful resource use. When sufficient EVPN e2e tests run in parallel, monitoring pathological event tracker picks this up and fails the job.

https://redhat.atlassian.net/browse/OCPBUGS-85087 will fix the tests to share the same VTEP resource. Until then, add an exception for the event.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[jcaamano]

/cherry-pick release-4.22

[openshift-cherrypick-robot]

@jcaamano: once the present PR merges, I will cherry-pick it on top of release-4.22 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-4.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[coderabbitai]

Walkthrough

A new pathological event matcher is added to detect CIDR overlaps between OVN Kubernetes and VTEP configurations. The matcher is registered in the universal set of monitorable events with specific message patterns and a Jira issue link.

Changes

OVN CIDR Overlap Event Matcher

Layer / File(s)	Summary
Event Matcher Registration pkg/monitortestlibrary/pathologicaleventlibrary/duplicated_event_patterns.go	New SimplePathologicalEventMatcher named OVNKubernetesCIDRsOverlapWithVTEPsEvents is registered with regex patterns for CIDROverlap reason and CIDRs overlap with VTEPs message, linked to OCPBUGS-84917.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

🚥 Pre-merge checks | ✅ 12

✅ Passed checks (12 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: adding an exception to allow OVN-Kubernetes CIDR overlap pathological events, which directly aligns with the code modification that registers a new event matcher for CIDR overlap detection.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PR adds a pathological event matcher configuration file and modifies regular Go unit tests. No Ginkgo test names are added or modified, so the check is not applicable.
Test Structure And Quality	✅ Passed	This check is for Ginkgo test code. The PR modifies a library file with event matcher definitions, not tests. No Ginkgo constructs present.
Microshift Test Compatibility	✅ Passed	PR does not add any Ginkgo e2e tests. Changes are limited to adding a pathological event matcher configuration in a monitoring library file, not test code. Custom check is not applicable.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	No Ginkgo e2e tests are added in this PR. Only a monitoring library file is modified to add event filtering. SNO compatibility check is not applicable.
Topology-Aware Scheduling Compatibility	✅ Passed	This modifies a test monitoring library to register an event matcher. Not a deployment, operator, or controller with scheduling constraints.
Ote Binary Stdout Contract	✅ Passed	PR modifies a library file adding a pathological event matcher. This is not an OTE binary entry point, and there are no stdout writes in the file.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	This PR does not add any Ginkgo e2e tests. It only modifies monitoring infrastructure (duplicated_event_patterns.go) to add a pathological event matcher. The custom check is not applicable.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci-robot]

@jcaamano: This pull request references Jira Issue OCPBUGS-85087, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.0.0) matches configured target version for branch (5.0.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

OVN-Kubernetes EVPN e2e tests when running in parallel create multiple VTEP resources with the same CIDR. OVN-Kubernetes logs this through events with no further consequence other than reporting the wasteful resource use. When sufficient EVPN e2e tests run in parallel, monitoring pathological event tracker picks this up and fails the job.

https://redhat.atlassian.net/browse/OCPBUGS-85087 will fix the tests to share the same VTEP resource. Until then, add an exception for the event.

Summary by CodeRabbit

• New Features
• Enhanced network monitoring capabilities to detect overlaps between OVN Kubernetes cluster network configurations and VTEP virtual tunnel endpoint network configurations. This improvement provides better visibility into potential network configuration conflicts, enabling proactive identification and resolution of compatibility issues that could affect cluster stability.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@pkg/monitortestlibrary/pathologicaleventlibrary/duplicated_event_patterns.go`:
- Around line 565-570: The Jira reference in the SimplePathologicalEventMatcher
block is inconsistent: update the inline comment and the jira field inside the
registry.AddPathologicalEventMatcherOrDie(&SimplePathologicalEventMatcher{...})
for the matcher named "OVNKubernetesCIDRsOverlapWithVTEPsEvents" to reference
the correct ticket OCPBUGS-85087 (replace the URL
"https://redhat.atlassian.net/browse/OCPBUGS-84917" and any nearby comment text
that mentions 84917 to 85087) so automation and reporting align with this PR.
- Around line 566-571: The matcher added via
registry.AddPathologicalEventMatcherOrDie using SimplePathologicalEventMatcher
with name "OVNKubernetesCIDRsOverlapWithVTEPsEvents" is too broad (matches only
by reason/message); narrow its scope by adding locatorKeyRegexes on the
SimplePathologicalEventMatcher to restrict matches to the OVN-related context
(e.g., require the event locator to include the OVN namespace and/or OVN
workload identity such as "namespace:ovn-" or specific pod/controller naming
patterns used by OVN), so update the struct to include locatorKeyRegexes:
[]regexp.Regexp{regexp.MustCompile(`...`), ...} that target the OVN
namespace/workload strings to prevent masking unrelated CIDROverlap regressions.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 0a171bdc-7cd9-454b-9d3a-69a898101a71

📥 Commits

Reviewing files that changed from the base of the PR and between 0de3cea and e7e6860.

📒 Files selected for processing (1)

• pkg/monitortestlibrary/pathologicaleventlibrary/duplicated_event_patterns.go

[jcaamano]

/test ?

[openshift-merge-bot]

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

[jcaamano]

/payload-job periodic-ci-openshift-ovn-kubernetes-release-5.0-periodics-e2e-metal-ipi-ovn-dualstack-bgp-local-gw-techpreview

[openshift-ci]

@jcaamano: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-ovn-kubernetes-release-5.0-periodics-e2e-metal-ipi-ovn-dualstack-bgp-local-gw-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/be13a660-4931-11f1-9c64-53ae7ba8d14e-0

[dgoodwin]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgoodwin, jcaamano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [dgoodwin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jcaamano]

/test ?

[jcaamano]

/verify later

[jcaamano]

/retest-required

[jcaamano]

/verify later @jcaamano

[jcaamano]

/verified later

[openshift-ci-robot]

@jcaamano: /verified later <@username> requires at least one GitHub @username to be specified (it can be a comma delimited list). It indicates the engineer(s) that will be performing the verification. See https://docs.ci.openshift.org/docs/architecture/jira/#premerge-verification for more information.

Details

In response to this:

/verified later

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[jcaamano]

/verified later @jcaamano

[openshift-ci-robot]

@jcaamano: This PR has been marked to be verified later by @jcaamano.

Details

In response to this:

/verified later @jcaamano

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@jcaamano: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@jcaamano: Jira Issue OCPBUGS-85087: All pull requests linked via external trackers have merged:

• openshift/origin#31131

This pull request has the verified-later tag and will need to be manually moved to VERIFIED after testing. Jira Issue OCPBUGS-85087 has been moved to the MODIFIED state.

Details

In response to this:

OVN-Kubernetes EVPN e2e tests when running in parallel create multiple VTEP resources with the same CIDR. OVN-Kubernetes logs this through events with no further consequence other than reporting the wasteful resource use. When sufficient EVPN e2e tests run in parallel, monitoring pathological event tracker picks this up and fails the job.

https://redhat.atlassian.net/browse/OCPBUGS-85087 will fix the tests to share the same VTEP resource. Until then, add an exception for the event.

Summary by CodeRabbit

• New Features
• Enhanced network monitoring capabilities to detect overlaps between OVN Kubernetes cluster network configurations and VTEP virtual tunnel endpoint network configurations. This improvement provides better visibility into potential network configuration conflicts, enabling proactive identification and resolution of compatibility issues that could affect cluster stability.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-cherrypick-robot]

@jcaamano: new pull request created: #31137

Details

In response to this:

/cherry-pick release-4.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-merge-robot]

Fix included in release 5.0.0-0.nightly-2026-05-07-054132