OCPBUGS-85828: Update catalogs for 4.23/5.0#734
Conversation
openshift-ci-robot
added
jira/severity-critical
|
@tmshort: This pull request references Jira Issue OCPBUGS-85828, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (5)
🚧 Files skipped from review as they are similar to previous changes (4)
WalkthroughClusterCatalog image refs and the Helm chart option were changed from ChangesCatalogd Configuration and Manifests
🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested labels: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 error, 2 warnings, 1 inconclusive)
✅ Passed checks (11 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
openshift-ci-robot
added
jira/valid-bug
|
@tmshort: This pull request references Jira Issue OCPBUGS-85828, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
tmshort
force-pushed
the
update-catalog-tag
branch
from
1441769 to
bd8cc25
Compare
|
@tmshort: This pull request references Jira Issue OCPBUGS-85828, which is valid. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest |
|
Hi @tmshort the default catalog tests uses the images from here so will fail see: |
I expected CI to fail (because those catalogs are not available yet), but did not consider the default-cartalog-consistency tests. Thanks. |
tmshort
force-pushed
the
update-catalog-tag
branch
from
bd8cc25 to
b3db3f1
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@openshift/default-catalog-consistency/test/validate/suite_test.go`:
- Around line 33-39: The suite setup currently uses fmt.Println in the var _ =
Describe initialization (see utils.ClusterCatalogVersion and the images loop)
which emits non-JSON stdout and leaks REGISTRY_AUTH_FILE; replace those
fmt.Println calls with GinkgoWriter (or fmt.Fprintln(os.Stderr, ...)) so output
goes to test logs/stderr instead of stdout, and remove or redact printing of the
REGISTRY_AUTH_FILE value (e.g., log that an auth file is configured without
printing the path). Ensure changes are applied where ClusterCatalogVersion() is
handled and in the second print near the REGISTRY_AUTH_FILE usage so no non-JSON
stdout is emitted during suite init.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 3b56e87e-9ee0-49e3-a5c1-a73d44857a2c
📒 Files selected for processing (5)
openshift/catalogd/manifests-experimental.yamlopenshift/catalogd/manifests.yamlopenshift/default-catalog-consistency/test/utils/utils.goopenshift/default-catalog-consistency/test/validate/suite_test.goopenshift/helm/catalogd.yaml
✅ Files skipped from review due to trivial changes (1)
- openshift/helm/catalogd.yaml
🚧 Files skipped from review as they are similar to previous changes (2)
- openshift/catalogd/manifests-experimental.yaml
- openshift/catalogd/manifests.yaml
Set catalog image tags to ocp-release and update the default-catalog-consistency test to resolve that imagestream tag to a concrete version (e.g. v4.22) by querying the cluster's ClusterVersion resource via oc/kubectl. Falls back to skipping when the cluster is not accessible. Fixes: OCPBUGS-85828 Assisted-by: Claude Signed-off-by: Todd Short <tshort@redhat.com>
tmshort
force-pushed
the
update-catalog-tag
branch
from
b3db3f1 to
6312355
Compare
3 participants
Set catalog image tags to ocp-release and update the default-catalog-consistency
test to resolve that imagestream tag to a concrete version (e.g. v4.22) by querying
the cluster's ClusterVersion resource via oc/kubectl. Falls back to skipping when
the cluster is not accessible.
Fixes: OCPBUGS-85828
Summary by CodeRabbit
Chores
Tests