[oadp-1.6] OADP-8483: Add startup probe to CLI and VMDP download servers

[NicholasYancey]

Why the changes were made

Adds a StartupProbe to the oadp-cli-server and oadp-vmdp-server deployments on oadp-1.6, matching what's already on dev/1.5. This gives slow-starting containers time to come up before liveness checks begin.

How to test the changes made

go test ./internal/controller/... -run 'CLIServer|VMDPServer' -v
oc get deploy -n openshift-adp openshift-adp-oadp-cli-server \
  -o jsonpath='{.spec.template.spec.containers[0].startupProbe}{"\n"}'
oc get deploy -n openshift-adp openshift-adp-oadp-vmdp-server \
  -o jsonpath='{.spec.template.spec.containers[0].startupProbe}{"\n"}'

[openshift-ci-robot]

@NicholasYancey: This pull request references OADP-8483 which is a valid jira issue.

Details

In response to this:

Why the changes were made

Adds a StartupProbe to the oadp-cli-server and oadp-vmdp-server deployments on oadp-1.6, matching what's already on dev/1.5. This gives slow-starting containers time to come up before liveness checks begin.

How to test the changes made

go test ./internal/controller/... -run 'CLIServer|VMDPServer' -v
oc get deploy -n openshift-adp openshift-adp-oadp-cli-server \
 -o jsonpath='{.spec.template.spec.containers[0].startupProbe}{"\n"}'
oc get deploy -n openshift-adp openshift-adp-oadp-vmdp-server \
 -o jsonpath='{.spec.template.spec.containers[0].startupProbe}{"\n"}'

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: e23bc076-06e9-468b-8e13-d621ecf2ab3e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[NicholasYancey]

/retest-required

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: NicholasYancey, sseago

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [sseago]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@NicholasYancey: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/5.0-e2e-test-kubevirt-aws	da882c3	link	true	/test 5.0-e2e-test-kubevirt-aws

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[NicholasYancey]

/retest