fix(deps): update github.com/openshift/lightspeed-agentic-operator/api digest to 8ac45f7#25
Open
red-hat-konflux[bot] wants to merge 1 commit into
Conversation
📝 WalkthroughWalkthroughThis PR updates go.mod to require a newer pseudo-version of github.com/openshift/lightspeed-agentic-operator/api (from v0.0.0-20260520064516-8235eff0226c to v0.0.0-20260602120900-8ac45f7db874); no other module lines were changed. ChangesAPI Dependency Version Update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested labels: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@go.mod`:
- Line 52: The API bump introduced a CRD-breaking change:
GoogleCloudVertexConfig.modelProvider (type GoogleCloudVertexModelProvider) is
now required, which will make existing LLMProvider CRs of kind GoogleCloudVertex
invalid; also SkillsSource.paths became optional. Update the repo to explicitly
call out this breaking change in the release notes/CHANGELOG and in upgrade
docs, and either add a migration/defaulting path (mutating webhook or controller
migration) to populate spec.googleCloudVertex.modelProvider for existing
resources or revert/change the API to make GoogleCloudVertexConfig.modelProvider
optional/defaulted; reference the types GoogleCloudVertexModelProvider and
GoogleCloudVertexConfig.modelProvider (api/v1alpha1/llmprovider_types.go and
api/v1alpha1/shared_types.go) and mention SkillsSource.paths is now optional so
callers and validation logic should be updated accordingly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 025b57c1-2b29-4be4-9bac-1fcd6cc443ca
📒 Files selected for processing (1)
go.mod
| github.com/monochromegane/go-gitignore v0.0.0-20200626010858-205db1a8cc00 // indirect | ||
| github.com/munnerz/goautoneg v0.0.0-20191010083416-a7dc8b61c822 // indirect | ||
| github.com/openshift/lightspeed-agentic-operator/api v0.0.0-20260520064516-8235eff0226c | ||
| github.com/openshift/lightspeed-agentic-operator/api v0.0.0-20260601102111-014eb39be821 |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Description: Compare API changes between old and new commit to identify breaking changes
cd api || exit 1
echo "=== Checking commit history between 8235eff0226c and 014eb39be821 ==="
git log --oneline 8235eff0226c..014eb39be821
echo -e "\n=== Files changed between commits ==="
git diff --name-only 8235eff0226c..014eb39be821
echo -e "\n=== Detailed diff of Go files (excluding generated/vendor) ==="
git diff 8235eff0226c..014eb39be821 -- '*.go' ':!vendor/**' ':!**/zz_generated.*'
echo -e "\n=== Checking for removed exported symbols ==="
# Look for removed exported types, functions, constants
git diff 8235eff0226c..014eb39be821 -- '*.go' | grep -E '^\-\s*(type|func|const|var)\s+[A-Z]'Repository: openshift/lightspeed-agentic-operator
Length of output: 4030
🏁 Script executed:
#!/bin/bash
set -euo pipefail
OLD=8235eff0226c
NEW=014eb39be821
# Show which api/v1alpha1 Go files changed
echo "=== Changed api/v1alpha1 Go files ==="
git diff --name-only "$OLD..$NEW" -- 'api/v1alpha1/*.go' 'api/v1alpha1/**/*.go' || true
# Confirm whether proposal-related symbols/types changed
echo -e "\n=== Diff for Proposal / Step related definitions (best-effort grep) ==="
git diff "$OLD..$NEW" -- 'api/v1alpha1/**/*.go' -- '*.go' | rg -n "type (Proposal|ProposalSpec|ProposalStep)|AddToScheme|ProposalCondition|SandboxStepAnalysis|StepResultRef|Steps\.|type .*Condition" || true
# Show exact diff hunks for the only api/v1alpha1 files we saw previously
echo -e "\n=== api/v1alpha1/llmprovider_types.go changes ==="
git diff "$OLD..$NEW" -- api/v1alpha1/llmprovider_types.go
echo -e "\n=== api/v1alpha1/shared_types.go changes ==="
git diff "$OLD..$NEW" -- api/v1alpha1/shared_types.goRepository: openshift/lightspeed-agentic-operator
Length of output: 3264
🏁 Script executed:
#!/bin/bash
set -euo pipefail
OLD=8235eff0226c
NEW=014eb39be821
echo "=== Where new ModelProvider field is referenced ==="
rg -n "ModelProvider|GoogleCloudVertexModelProvider" .
echo -e "\n=== What changed in example YAMLs/CRD bases between commits (non-go) ==="
git diff --name-only "$OLD..$NEW" -- 'config/**' 'examples/**' || true
echo -e "\n=== Show diff for CRD and examples touching Vertex config ==="
# Limit output to likely files
for f in \
config/crd/bases/agentic.openshift.io_llmproviders.yaml \
examples/setup/00-llm-providers.yaml
do
if git show "$NEW:$f" >/dev/null 2>&1; then
echo -e "\n--- $f ---"
git diff "$OLD..$NEW" -- "$f" || true
fi
done
echo -e "\n=== Does the codebase set any default for modelProvider (if omitted)? ==="
rg -n "default.*modelProvider|modelProvider.*default|omitempty.*modelProvider" .Repository: openshift/lightspeed-agentic-operator
Length of output: 4429
🏁 Script executed:
#!/bin/bash
set -euo pipefail
nl -ba go.mod | sed -n '70,95p'Repository: openshift/lightspeed-agentic-operator
Length of output: 124
🏁 Script executed:
#!/bin/bash
set -euo pipefail
awk '{printf "%d\t%s\n", NR, $0}' go.mod | sed -n '80,95p'Repository: openshift/lightspeed-agentic-operator
Length of output: 437
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "=== Root ./api directory structure (shallow) ==="
ls -la api | head -n 50
echo -e "\n=== Does ./api contain controller/ ? ==="
test -d api/controller && echo "YES: api/controller exists" || echo "NO: api/controller missing"
echo -e "\n=== Does ./controller exist at repo root? ==="
test -d controller && echo "YES: controller exists" || echo "NO: controller missing"Repository: openshift/lightspeed-agentic-operator
Length of output: 556
🏁 Script executed:
#!/bin/bash
set -euo pipefail
rg -n "GoogleCloudVertexConfig|GoogleCloudVertexModelProvider|ModelProvider" .Repository: openshift/lightspeed-agentic-operator
Length of output: 2829
🏁 Script executed:
#!/bin/bash
set -euo pipefail
rg -n "modelProvider|GoogleCloudVertexModelProvider" -- '*.go' .Repository: openshift/lightspeed-agentic-operator
Length of output: 2460
🏁 Script executed:
#!/bin/bash
set -euo pipefail
rg -n "modelProvider|GoogleCloudVertexModelProvider" --glob='*.go' .Repository: openshift/lightspeed-agentic-operator
Length of output: 1688
🏁 Script executed:
#!/bin/bash
set -euo pipefail
rg -n "GoogleCloudVertexConfig|googleCloudVertex|GoogleCloudVertex" --glob='*.go' .Repository: openshift/lightspeed-agentic-operator
Length of output: 6524
Call out CRD-breaking change in API bump (GoogleCloudVertex.modelProvider is now required)
go.modline 52 updates the api pseudo-version, butreplace ... => ./api(line 87) means this repo builds against the local./api.- The API commit delta only changes
api/v1alpha1/llmprovider_types.goandapi/v1alpha1/shared_types.go: addsGoogleCloudVertexModelProvider+GoogleCloudVertexConfig.modelProviderand makesSkillsSource.pathsoptional. - No changes to Proposal/Step/scheme registration/condition/status types were introduced, and no exported symbol removals were detected.
- Breaking impact: the updated CRD marks
spec.googleCloudVertex.modelProvideras required; existingLLMProviderobjects of typeGoogleCloudVertexthat omit it will be rejected by the CRD.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@go.mod` at line 52, The API bump introduced a CRD-breaking change:
GoogleCloudVertexConfig.modelProvider (type GoogleCloudVertexModelProvider) is
now required, which will make existing LLMProvider CRs of kind GoogleCloudVertex
invalid; also SkillsSource.paths became optional. Update the repo to explicitly
call out this breaking change in the release notes/CHANGELOG and in upgrade
docs, and either add a migration/defaulting path (mutating webhook or controller
migration) to populate spec.googleCloudVertex.modelProvider for existing
resources or revert/change the API to make GoogleCloudVertexConfig.modelProvider
optional/defaulted; reference the types GoogleCloudVertexModelProvider and
GoogleCloudVertexConfig.modelProvider (api/v1alpha1/llmprovider_types.go and
api/v1alpha1/shared_types.go) and mention SkillsSource.paths is now optional so
callers and validation logic should be updated accordingly.
red-hat-konflux
Bot
changed the title
red-hat-konflux
Bot
force-pushed
the
konflux/mintmaker/main/github.com-openshift-lightspeed-agentic-operator-api-digest
branch
from
de6f064 to
82017cc
Compare
…i digest to 8ac45f7 Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
red-hat-konflux
Bot
changed the title
red-hat-konflux
Bot
force-pushed
the
konflux/mintmaker/main/github.com-openshift-lightspeed-agentic-operator-api-digest
branch
from
82017cc to
41a769a
Compare
|
@red-hat-konflux[bot]: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Contributor
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: onmete The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
8235eff→8ac45f7Warning
Some dependencies could not be looked up. Check the warning logs for more information.
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
To execute skipped test pipelines write comment
/ok-to-test.Documentation
Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.