[release-4.22] OCPBUGS-86293: update INFW to 4.22 version#712
Conversation
Bump Go version from 1.24.0 to 1.25.0 to satisfy controller-gen@v0.20.1 requirement (requires Go >= 1.25.0). Update go.mod and all Dockerfiles to use Go 1.25 for consistency. Fix test case that was using TCP field with UDP protocol type. The updated controller-gen enforces stricter validation where protocol type must match the field used in protocolConfig. Update Makefile to use modern setup-envtest Go binary instead of deprecated shell script that was failing with 403 errors from Google Cloud Storage. Align versions with project dependencies: ENVTEST_K8S_VERSION: 1.25.2 → 1.32.x (matches k8s.io/* v0.32.3) CONTROLLER_TOOLS_VERSION: v0.14.0 → v0.20.1 (matches controller-runtime v0.20.4) setup-envtest pinned to v0.20.4 (matches controller-runtime v0.20.4) Add GOFLAGS="" to setup-envtest install to fix -mod=vendor CI errors Regenerate CRDs and RBAC with updated controller-gen. Signed-off-by: Raphael Rosa <raprosa@redhat.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@openshift-cherrypick-robot: Jira Issue OCPBUGS-79056 has been cloned as Jira Issue OCPBUGS-86293. Will retitle bug to link to clone. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
|
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-86293, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@danwinship: This pull request references Jira Issue OCPBUGS-86293, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@danwinship: The label(s) DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
hm... flake? hopefully? |
|
@openshift-cherrypick-robot: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: openshift-cherrypick-robot, raphaelvrosa The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This is an automated cherry-pick of #707
/assign danwinship