Skip to content

Merge https://github.com/openshift/hypershift-oadp-plugin:main (f8c5bfb) into main - #298

Open
oadp-rebasebot-app[bot] wants to merge 1 commit into
openshift:mainfrom
oadp-rebasebot:rebase-bot-main
Open

Merge https://github.com/openshift/hypershift-oadp-plugin:main (f8c5bfb) into main#298
oadp-rebasebot-app[bot] wants to merge 1 commit into
openshift:mainfrom
oadp-rebasebot:rebase-bot-main

Conversation

@oadp-rebasebot-app

@oadp-rebasebot-app oadp-rebasebot-app Bot commented Jul 21, 2026

Copy link
Copy Markdown

This is an automated rebase PR generated by RebaseBot.

Summary

  • Source: https://github.com/openshift/hypershift-oadp-plugin:main
  • Destination: https://github.com/openshift/hypershift-oadp-plugin:main
  • 0 new upstream commits

Summary by CodeRabbit

  • Bug Fixes
    • Updated Velero API compatibility to use the OpenShift-maintained implementation.
    • Improved reliability for features that depend on Velero API integrations.

@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 82956e59-ca8c-4f55-8be7-5b5a42d73db5

📥 Commits

Reviewing files that changed from the base of the PR and between f8c5bfb and 90d971c.

⛔ Files ignored due to path filters (2)
  • go.sum is excluded by !**/*.sum
  • vendor/modules.txt is excluded by !**/vendor/**, !vendor/**
📒 Files selected for processing (1)
  • go.mod

Walkthrough

The Go module configuration adds a replacement for github.com/vmware-tanzu/velero/pkg/apis, resolving it to the OpenShift Velero API module at a specified version.

Changes

Velero API resolution

Layer / File(s) Summary
Configure Velero API replacement
go.mod
Adds a replace directive mapping the VMware Velero API submodule to the OpenShift Velero API module version.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: kaovilai

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects this automated merge/rebase PR into main, which matches the change being merged.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed Only module files changed; no test titles were added or edited.
Test Structure And Quality ✅ Passed PR only changes go.mod/go.sum/vendor metadata; no Ginkgo test code was added or modified, so the test-quality check is not applicable.
Microshift Test Compatibility ✅ Passed Only go.mod/go.sum/vendor metadata changed; no new Ginkgo tests or OpenShift API usage were added.
Single Node Openshift (Sno) Test Compatibility ✅ Passed Only module files changed (go.mod/go.sum/vendor); no Ginkgo e2e tests were added or modified.
Topology-Aware Scheduling Compatibility ✅ Passed Only module metadata changed (go.mod/go.sum/vendor/modules.txt); no deployment manifests, operators, or controllers were modified, so no new scheduling constraints.
Ote Binary Stdout Contract ✅ Passed Diff only updates module metadata/replace directives in go.mod, go.sum, and vendor/modules.txt; no main/init/test-suite stdout writes were introduced.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed Only go.mod/go.sum/vendor metadata changed; no new Ginkgo e2e tests or network-sensitive code were added.
No-Weak-Crypto ✅ Passed Only go.mod/go.sum/vendor metadata changed to replace velero pkg/apis; no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB or custom crypto found.
Container-Privileges ✅ Passed PR only changes go.mod/go.sum/vendor/modules.txt; no K8s/container manifests or privilege-related fields are present.
No-Sensitive-Data-In-Logs ✅ Passed Only go.mod, go.sum, and vendor/modules.txt changed; no logging code or sensitive literals were added or modified.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from Joeavaikath and kaovilai July 21, 2026 20:57
@openshift-ci openshift-ci Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 21, 2026
@openshift-ci

openshift-ci Bot commented Jul 21, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: oadp-rebasebot-app[bot]
Once this PR has been reviewed and has the lgtm label, please assign sjenning for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Jul 21, 2026

Copy link
Copy Markdown

Hi @oadp-rebasebot-app[bot]. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant